Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit and deCLAW for #1267 #15

Merged
merged 4 commits into from
Oct 21, 2019
Merged

Audit and deCLAW for #1267 #15

merged 4 commits into from
Oct 21, 2019

Conversation

manez
Copy link
Member

@manez manez commented Oct 17, 2019

GitHub Issue: Islandora/documentation#1267

What does this Pull Request do?

Updates the readme and conrtibuting.md to match the readme template and remove all possible references to CLAW.

What's new?

Some new sections in the readme, shuffling a few things around, updating a lot of links.

How should this be tested?

Preview and review. I wasn't sure what to do with the requirements section, since this module seems to have a ton of them but most are core (?). Installation and Configuration are a bit vague too. Could use more expert input, but at least it's moving into the right form.

Additional Notes:

Last remaining CLAW reference in the docs I touched is the playbook, which still has CLAW baked into the url.

If the updates to contributing.md are approved, it can serve as a copy+paste template to update those links across the board.

Interested parties

@seth-shaw-unlv

manez added 3 commits October 17, 2019 15:25
de-CLAWed once and for all!
little travis fix
Copy link
Contributor

@seth-shaw-unlv seth-shaw-unlv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the 'If you want to pull down the submodules..." only applies to the project repository; not to islandora_defaults.

README.md Outdated Show resolved Hide resolved
@manez
Copy link
Member Author

manez commented Oct 21, 2019

@seth-shaw-unlv how's it looking now? Don't mean to be a pest, but I want to use the CONTRIBUTING.md off this one for others 😄

@seth-shaw-unlv
Copy link
Contributor

No worries. I just got in the office for the day. I've been working with sick kids all weekend.

@seth-shaw-unlv seth-shaw-unlv merged commit 1d33fbf into Islandora:8.x-1.x Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants