Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to Mablibre #1532

Closed
HarelM opened this issue Jun 10, 2021 · 1 comment · Fixed by #1536
Closed

Migrate to Mablibre #1532

HarelM opened this issue Jun 10, 2021 · 1 comment · Fixed by #1536
Assignees
@HarelM
Labels
enhancement High Needed but there's a work around
Milestone
Version 9.9.76

Comments

@HarelM
Copy link
Member

HarelM commented Jun 10, 2021 •
edited
Loading

Infra

Currently the site uses mapbox-gl with a patch to add the custom sources.
I have created a PR for maplibre to have it there.
maplibre/maplibre-gl-js#30
@HarelM HarelM added enhancement High Needed but there's a work around labels Jun 10, 2021
@HarelM HarelM added this to the Next Release milestone Jun 10, 2021
@HarelM HarelM self-assigned this Jun 10, 2021
HarelM added a commit that referenced this issue Jun 16, 2021
@HarelM
Migrate to Mablibre #1532 - main commit
561458c
HarelM added a commit that referenced this issue Jun 16, 2021
@HarelM
Migrate to Mablibre #1532 - update package lock
f1f84e3
@HarelM
Copy link
Member Author

HarelM commented Jun 17, 2021

Summary of current status:

  1. I have write access to maplibre
  2. I added typings into the repository
  3. I pushed a rc to npm to allow the usage of the typings
  4. I created a fork of ngx-mapbox-gl called ngx-maplibre-gl and published that into npm
  5. I tested locally that the migration passed using basic tests
  6. I will try and progress the merge of the custom protocol so I can fully migrate to maplibre and test this on android as well.

This is starting to look good :-)

@HarelM HarelM mentioned this issue Jun 18, 2021
Merged
HarelM added a commit that referenced this issue Jun 18, 2021
@HarelM
MapLibre migration (#1536)
99b72ae 
* Migrate to Mablibre #1532 - main commit

* Migrate to Mablibre #1532 - update package lock

* Upgraded maplibre to a version that includes custom source
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HarelM HarelM

Labels
enhancement High Needed but there's a work around
Projects
None yet
Milestone
Version 9.9.76
Development

Successfully merging a pull request may close this issue.

MapLibre migration IsraelHikingMap/Site
1 participant
@HarelM