Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Unit tests. #1

Merged
merged 2 commits into from
Jun 18, 2018
Merged

Fix Unit tests. #1

merged 2 commits into from
Jun 18, 2018

Conversation

tapashmajumder
Copy link
Contributor

  1. Fix Unit tests.
  2. Add dependency injection via protocols and remove OCMock.

@tapashmajumder
1. Fix Unit tests.
e483fb9 
2. Add protocol dependency injection and remove OCMock.
vbabenkoru
vbabenkoru approved these changes Jun 18, 2018
View reviewed changes
Copy link
Contributor

@vbabenkoru vbabenkoru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish there was an easier way to do mocks in Swift, but it appears that it's the only way.
LGTM

swift-sdk/IterableAppIntegrationInternal.swift Outdated

/**
* This method handles user actions on incoming Iterable notifications
* Call it from your notification center delegate's userNotificationCenter:didReceiveNotificationResponse:withCompletionHandler:.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it shouldn't mention this since it's an internal implementation.

swift-sdk/IterableAppIntegrationInternal.swift Outdated

/**
* This method handles incoming Iterable notifications and actions for iOS < 10
* Call it from your app delegate's application:didReceiveRemoteNotification:fetchCompletionHandler:.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

@tapashmajumder tapashmajumder merged commit 6aa1401 into master Jun 18, 2018
davidtruong
davidtruong reviewed Jun 18, 2018
View reviewed changes
Copy link
Contributor

@davidtruong davidtruong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFTM

@tapashmajumder
Copy link
Contributor Author

Since these fixes have a lot to do with unit tests and should not impact the functionality much I am merging and deleting.

@tapashmajumder tapashmajumder deleted the fix-broken-unit-tests branch June 18, 2018 21:09
This was referenced Sep 15, 2022
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtruong davidtruong davidtruong left review comments

@vbabenkoru vbabenkoru vbabenkoru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tapashmajumder @davidtruong @vbabenkoru