Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MOB-5940] version 6.4.12 #614

Merged
merged 4 commits into from
Mar 28, 2023
Merged

[MOB-5940] version 6.4.12 #614

merged 4 commits into from
Mar 28, 2023

Conversation

roninopf
Copy link
Contributor

@roninopf roninopf commented Mar 28, 2023

🔹 Jira Ticket(s)

✏️ Description

Please provide a brief description of what this pull request does.

@roninopf roninopf requested a review from Ayyanchira March 28, 2023 00:12
Copy link
Member

@Ayyanchira Ayyanchira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments

@@ -2,6 +2,14 @@
All notable changes to this project will be documented in this file.
This project adheres to [Semantic Versioning](http://semver.org/).

## 6.4.11
### Added
- Added a new function to `IterableAPI` to get the currently set authentication token
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new failure handler which gets called when passed an invalid auth token or null?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OOPS good catch

### Changed
- Changed `setEmail` and `setUserId` to run through the login process if also sent in an authentication token (and a non-`nil` ID)
- Changed authentication manager behavior to schedule automatic refreshes on JWT retrieval or decoding failures

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes instances where setting a new authToken for same user failed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OOPS I like this too

Copy link
Member

@Ayyanchira Ayyanchira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roninopf roninopf merged commit ef4811d into master Mar 28, 2023
@roninopf roninopf deleted the MOB-5940-version-6.4.12 branch March 28, 2023 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants