Mob 8058 (Web SDK: Click Handling)

[hani-iterable]

JIRA Ticket(s) if any

• MOB-8058

Description

We have implemented Web click handling for embedded OOTB views.

[mprew97]

Thanks a ton for the quick turnaround here! Have a few comments to address.

[mprew97]

can we remove the console statement?

[hani-iterable]

Done

[mprew97]

shouldn't this be of type EmbeddedMessage?

[hani-iterable]

I have set 'IterableEmbeddedMessage' as it already exists and match with the Android SDK.

[mprew97]

we don't need the | '' since that is just a string.

[hani-iterable]

Done

[mprew97]

We shouldn't be tracking the click if there is nothing found in local storage. Shouldn't happen, but we should account for it. And ideally, email and userId should be fields passed in to this method so that the search for local storage is handled outside the scope of this method.

[hani-iterable]

I've implemented a check for both the email and userId in the Android SDK, following the same approach used in other methods. During API calls, the email and userId are added to the request, ensuring consistency across our SDK architectures.

[bradumbaugh]

Could we clarify this? Maybe call the Card's attribute message (instead of messageData) and then pass in a message, rather than data? The idea here is that we're passing in the message to be rendered... I think talking about "data" removes a bit of clarity

[hani-iterable]

Done

[bradumbaugh]

What is "parentStyle"? Just want to be sure I understand what this is / why it's named that way

[hani-iterable]

The 'parentStyle' will set the style to the parent view of all the components like background, borderRadius, etc.

[bradumbaugh]

Same comment as above about messageData. Won't keep calling this out, but I think my comment is valid for banner / notification / card

[hani-iterable]

Done

[bradumbaugh]

messageData vs message again

[hani-iterable]

Done

[bradumbaugh]

Should it receive an IterableEmbeddedMessage object, instead of EmbeddedMessageData?

[hani-iterable]

We can't. IterableEmbeddedMessage is responsible for determining the message type received, while EmbeddedMessageData contains the properties needed for custom styling of Out-of-the-Box (OOTB) views.

[bradumbaugh]

IterableEmbeddedMessage instead of EmbeddedMessagData?

[hani-iterable]

We can't. IterableEmbeddedMessage is responsible for determining the message type received, while EmbeddedMessageData contains the properties needed for custom styling of Out-of-the-Box (OOTB) views.

[bradumbaugh]

IterableEmbeddedMessage instead of EmbeddedMessageData?

[hani-iterable]

We can't. IterableEmbeddedMessage is responsible for determining the message type received, while EmbeddedMessageData contains the properties needed for custom styling of Out-of-the-Box (OOTB) views.

[bradumbaugh]

@hani-iterable What is this config needed for?

[hani-iterable]

No need for that. I have removed.

[bradumbaugh]

Left some minor comments / questions

[mprew97]

Also, this is kind of a late catch, but can we remove instances of manually setting email and user id on local storage in the Web SDK source? We already have methods that customers/devs use to do that. You can see we have a setEmail and setUserId on the initialize() method we are already using for embedded in the react-example app.

We should just be able to fetch from local storage without having to set it, except for when setUser and setUserId is called.

See the method definition in authorization.ts. To use it, you would just call

const { setEmail, setUserId } = initialize(...)

[hani-iterable]

initialize()

@mprew97 Got it, you're asking about the use of the 'initialize()' method. Do we need to pass the userID from the Sample app when calling any method related to Embedded messages, or is there another way to handle this?

[mprew97]

initialize()

@mprew97 Got it, you're asking about the use of the 'initialize()' method. Do we need to pass the userID from the Sample app when calling any method related to Embedded messages, or is there another way to handle this?

@hani-iterable For API requests, once you call setEmail or setUserId, those automatically get tacked on to all requests. In authorization.ts, see lines 237 - 328. We intercept any request using baseAxiosRequest and add the email or userId to the req.

[bradumbaugh]

Thank you!