Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MOB-9087] Properly format query params for GET requests #418

Merged
merged 1 commit into from
Jul 17, 2024
Merged

[MOB-9087] Properly format query params for GET requests #418

merged 1 commit into from
Jul 17, 2024

Conversation

mprew97
Copy link
Contributor

@mprew97 mprew97 commented Jul 11, 2024 •
edited
Loading

JIRA Ticket(s) if any

Description

Test Steps

  1. In the EmbeddedMsgs view in the sample app, pass in additional params to syncMessages for the placementIds arg.
  2. When getMessages is called, make sure the params passed in are properly serialized for a URL.
  3. Test this for api-inapp as well.
Screenshot 2024-07-11 at 11 28 53 AM Screenshot 2024-07-11 at 11 27 56 AM

@mprew97 mprew97 merged commit 082fee6 into main Jul 17, 2024
1 check passed
@mprew97 mprew97 deleted the MOB-9087 branch July 17, 2024 13:35
@bradumbaugh bradumbaugh changed the title [MOB-9087]: properly format query params for get requests [MOB-9087] Properly format query params for GET requests Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lposen lposen lposen approved these changes

@pauljung14 pauljung14 pauljung14 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mprew97 @lposen @pauljung14