GraphQLField: relax default value of TArgs to any

Fixes graphql#2152 Fixes graphql#2829
IvanGoncharov · Oct 23, 2021 · 3fbc1a1 · 3fbc1a1
1 parent 52f1754
commit 3fbc1a1
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 20 deletions.
diff --git a/integrationTests/ts/basic-test.ts b/integrationTests/ts/basic-test.ts
@@ -9,10 +9,13 @@ const queryType: GraphQLObjectType = new GraphQLObjectType({
     sayHi: {
       type: GraphQLString,
       args: {
-        who: { type: GraphQLString },
+        who: {
+          type: GraphQLString,
+          defaultValue: 'World',
+        },
       },
-      resolve(_root, args) {
-        return 'Hello ' + (args.who ?? 'World');
+      resolve(_root: any, args: { who: string }) {
+        return 'Hello ' + args.who;
       },
     },
   }),
@@ -23,7 +26,7 @@ const schema: GraphQLSchema = new GraphQLSchema({ query: queryType });
 const result: ExecutionResult = graphqlSync({
   schema,
   source: `
-    query helloWho($who: String){
+    query helloWho($who: String!){
       test(who: $who)
     }
   `,

diff --git a/src/type/definition.ts b/src/type/definition.ts
@@ -962,7 +962,7 @@ export type GraphQLIsTypeOfFn<TSource, TContext> = (
 export type GraphQLFieldResolver<
   TSource,
   TContext,
-  TArgs = { [argument: string]: any },
+  TArgs = any,
   TResult = unknown,
 > = (
   source: TSource,
@@ -996,19 +996,11 @@ export interface GraphQLResolveInfo {
  * We've provided these template arguments because this is an open type and
  * you may find them useful.
  */
-export interface GraphQLFieldExtensions<
-  _TSource,
-  _TContext,
-  _TArgs = { [argName: string]: any },
-> {
+export interface GraphQLFieldExtensions<_TSource, _TContext, _TArgs = any> {
   [attributeName: string]: unknown;
 }
 
-export interface GraphQLFieldConfig<
-  TSource,
-  TContext,
-  TArgs = { [argument: string]: any },
-> {
+export interface GraphQLFieldConfig<TSource, TContext, TArgs = any> {
   description?: Maybe<string>;
   type: GraphQLOutputType;
   args?: GraphQLFieldConfigArgumentMap;
@@ -1049,11 +1041,7 @@ export type GraphQLFieldConfigMap<TSource, TContext> = ObjMap<
   GraphQLFieldConfig<TSource, TContext>
 >;
 
-export interface GraphQLField<
-  TSource,
-  TContext,
-  TArgs = { [argument: string]: any },
-> {
+export interface GraphQLField<TSource, TContext, TArgs = any> {
   name: string;
   description: Maybe<string>;
   type: GraphQLOutputType;