Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate some bevy changes #17

Closed
wants to merge 2 commits into from
Closed

migrate some bevy changes #17

wants to merge 2 commits into from

Conversation

bayou-brogrammer
Copy link

  1. Bevy time is now exported from bevy_time package bevyengine/bevy@644bd5d
  2. Bevy removed Ortho camera and UI Camera. The 3d/2d cameras now handle UI elements [Merged by Bors] - Camera Driven Rendering bevyengine/bevy#4745
  3. bevy::input::system::exit_on_esc_system is now bevy::window::close_on_esc
  4. Rect is now UIRect for UI Elements
  5. as_system_label is now not needed. (Screenshot taken from bevy source)

CleanShot 2022-06-14 at 13 57 27@2x

@inodentry
Copy link
Contributor

Most of your changes are formatting changes. I'm guessing you either ran cargo fmt or your editor has auto-formatting. Could you please not do that? It makes it very hard to see what the commit actually changes.

I am personally not a fan of enforcing rustfmt autoformatting in my projects. I would rather everyone just commit things with some sensible (even if inconsistent) formatting in the first place, and avoid the noise/spam of the autoformatter.

@bayou-brogrammer
Copy link
Author

bayou-brogrammer commented Jun 15, 2022

Ah yeah I can fix it and try again. Pretty sure my vscode runs it automatically

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants