[arrowheads] Warn if no strokeWidth is given

For use of console.warn see: mui/material-ui#15343
Izhaki · Sep 29, 2019 · e6875a4 · e6875a4
1 parent be083c4
commit e6875a4
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -31,7 +31,7 @@ module.exports = {
   },
   rules: {
     'no-alert': 'error',
-    //    'no-console': 'error',
+    'no-console': ['error', { allow: ['warn', 'error'] }],
     'no-constant-condition': 'error',
     'no-param-reassign': 'off',
     'no-prototype-builtins': 'off',

diff --git a/packages/arrowheads/src/withMarker.jsx b/packages/arrowheads/src/withMarker.jsx
@@ -30,7 +30,13 @@ export default WrappedComponent => {
 
   withMarker.getTrim = (props, strokeWidth) => {
     const { anchor } = WrappedComponent.getMarkerProps(props);
-    return (1 - anchor) * props.width * strokeWidth;
+    const trim = (1 - anchor) * props.width * (strokeWidth || 1);
+    if (trim !== 0 && !strokeWidth) {
+      console.warn(
+        `Regraph: a ${WrappedComponent.name} marker may not render correctly as no 'strokeWidth' property was provided to the connection.`
+      );
+    }
+    return trim;
   };
 
   withMarker.propTypes = {