Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize PHP extension requirements in composer.json #49

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

SmetDenis
Copy link
Member

The PHP extension dependencies have been shifted from the "require" block to the "require-dev" block in the composer.json file. These extensions are not integral to the project's functionality, but are needed in development and testing environments.

The PHP extension dependencies have been shifted from the "require" block to the "require-dev" block in the composer.json file. These extensions are not integral to the project's functionality, but are needed in development and testing environments.
@coveralls
Copy link

coveralls commented Mar 22, 2024

Coverage Status

coverage: 92.758%. remained the same
when pulling 59add57 on move-mods-to-suggest
into 0b9863c on master.

The conditional check for an empty string or null variable has been improved in the Xml.php file. Instead of using the isStrEmpty() function, an optimized approach was adopted using direct comparison with an empty string and null. This enhanced the efficiency of the XML load operation.
@SmetDenis SmetDenis merged commit 4630245 into master Mar 22, 2024
20 checks passed
@SmetDenis SmetDenis deleted the move-mods-to-suggest branch March 22, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants