Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix escaping of backslashes in regex and test cases #53

Merged
merged 4 commits into from
Jun 22, 2024
Merged

Conversation

SmetDenis
Copy link
Member

Correct improper escaping of backslashes in preg_replace regex patterns and test cases to ensure consistent handling of file paths. This change improves code reliability by accurately processing path separators and ensures the test cases correctly reflect expected outcomes. This update is crucial for environments where mixed path separators could lead to potential issues.

Correct improper escaping of backslashes in preg_replace regex patterns and test cases to ensure consistent handling of file paths. This change improves code reliability by accurately processing path separators and ensures the test cases correctly reflect expected outcomes. This update is crucial for environments where mixed path separators could lead to potential issues.
@coveralls
Copy link

Coverage Status

coverage: 92.75%. remained the same
when pulling 10898d4 on update-deps
into d8a1733 on master.

Clean up trailing whitespace to improve code readability and maintain coding standards. This change contributes to a cleaner codebase and helps prevent potential issues related to unnecessary whitespace.
@coveralls
Copy link

Coverage Status

coverage: 92.766%. remained the same
when pulling 29ba061 on update-deps
into 15d5e40 on master.

Add a check to ensure that the file size is greater than zero before attempting to read its contents. This prevents unnecessary operations and potential errors when trying to read empty files, improving the robustness of the file handling logic.
@SmetDenis SmetDenis merged commit 346c3b2 into master Jun 22, 2024
19 checks passed
@SmetDenis SmetDenis deleted the update-deps branch June 22, 2024 09:31
@coveralls
Copy link

Coverage Status

coverage: 92.722% (-0.04%) from 92.766%
when pulling ea6468d on update-deps
into 15d5e40 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

coverage: 92.722% (-0.04%) from 92.766%
when pulling ea6468d on update-deps
into 15d5e40 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants