Add version statement for netcdf-c version 4.9.1 #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
climbfuji
reviewed
Feb 9, 2023
|
I'm not clear if the change in this PR caused the CI test failure on the macos. The error messages in the macos test results seem to be saying that the test framework could not figure out which version to test. Should we hold off merging until this compile issue is resolved: Unidata/netcdf-c#2614 My preference would be to go ahead and merge, since we know the new version statement is correct, to facilitate coming up with a workaround (if that is the action we decide to take). But, only do so if we can insulate everything from this change (ie, leave configurations specifying netcdf-c@4.9.0 as is). |
|
This PR will be converted to "merged" status automatically when #221 and JCSDA/spack-stack#454 get merged, no need to do anything for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply adds the version statement to the netcdf-c package.py script so that we can start experimenting with netcdf-c 4.9.1.
I tried building with this change and I verified that the tar file download successfully, the unpacking of the tar file succeeded, and the execution of the configure script completed successfully. However, the build (compile) step fails. Because of this, I have not changed any default configurations so netcdf-c 4.9.0 will be the newest version used anywhere and that version successfully builds.
This change is partially addressing JCSDA/spack-stack/issues/453