Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CMakeLists.txt for new data download logic, update fv3-jedi/fv3-jedi-data branches from develop #41

Merged
merged 4 commits into from
Oct 20, 2023
Merged

Update CMakeLists.txt for new data download logic, update fv3-jedi/fv3-jedi-data branches from develop #41

merged 4 commits into from
Oct 20, 2023

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Oct 20, 2023 •
edited
Loading

Description

  1. Update CMakeLists.txt for new data download logic
  2. Update fv3-jedi/fv3-jedi-data branches from develop
  3. Replace ecbuild command with cmake command everywhere
  4. Simplify logic around UFS_APP choice

Issue(s) addressed

Part of data download PRs

Dependencies

https://github.com/JCSDA-internal/fv3-jedi/pull/1057
JCSDA-internal/fv3-jedi-data#85

Impact

n/a

Checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have run the unit tests before creating the PR: CI tests pass, also locally on my macOS

@climbfuji climbfuji mentioned this pull request Oct 20, 2023
Merged
3 tasks
@climbfuji climbfuji marked this pull request as ready for review October 20, 2023 20:05
@climbfuji climbfuji self-assigned this Oct 20, 2023
@climbfuji climbfuji added the INFRA JEDI Infrastructure label Oct 20, 2023
fmahebert
fmahebert previously approved these changes Oct 20, 2023
View reviewed changes
climbfuji
climbfuji commented Oct 20, 2023
View reviewed changes
Copy link
Collaborator Author

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-review,.

@climbfuji
Copy link
Collaborator Author

Thanks very much for your reviews @fmahebert, glad we get ufs-bundle CI fixed before the weekend.

@climbfuji climbfuji merged commit 8584482 into develop Oct 20, 2023
1 check passed
@climbfuji climbfuji deleted the feature/cmake_download branch October 20, 2023 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmahebert fmahebert fmahebert left review comments

@cmgas cmgas Awaiting requested review from cmgas

@shlyaeva shlyaeva Awaiting requested review from shlyaeva

Assignees

@climbfuji climbfuji

Labels
INFRA JEDI Infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@climbfuji @fmahebert