-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alpha and Volscl impact RF output #745
Conversation
Description: Previous Behavior: The graphs below illustrate this issue for runs with different values of alpha/volscl. Note how temperature correctly changes but radiative forcing values remain the same. New Behavior: Additionally, there are new unit tests that check to confirm that these two parameters have the expected impacts on their respective radiative forcings. The graphs below show the new model behavior when varying alpha and volscl. Comparison: Comparing the data frames from the default run between the dev and alpha_volcl versions of Hector, there was no change in any of the output values for total RF, ocean heat flux, global temperature, or CO2 concentrations. This is reflected in the following plot, which shows that the default runs produce the same results for both Hector versions. When we adjust alpha or volscl, the new runs now reflect those changes in RF values but have identical temperature values. This is expected, since this PR is not meant to change the actual effect of alpha/volscl, just where it’s being applied. Graphs showing this trend are given below: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely documented and an extremely sensible change! It looks great overall, though a few things to consider below.
project_files/Xcode/hector.xcodeproj/xcshareddata/xcschemes/ssp245.xcscheme
Outdated
Show resolved
Hide resolved
I guess one question for @bpbond cause this is a code-breaking change it would probably be part of a V4 release... does that mean that it should go into a different dev branch? if we are thinking about doing to another V3 release? But that might be a bigger question about how we want to manage Hector releases and stuff |
Differences in Hector outputsHello, this is The current pull request's outputs do not differ from 3.1.1 (d931a00). |
Differences in Hector outputsHello, this is The current pull request's outputs do not differ from 3.1.1 (d931a00). |
I just pushed two commits to rename |
Differences in Hector outputsHello, this is The current pull request's outputs do not differ from 3.1.1 (d931a00). |
Should resolve #743