Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alpha and Volscl impact RF output #745

Merged
merged 7 commits into from
Jul 18, 2024
Merged

Alpha and Volscl impact RF output #745

merged 7 commits into from
Jul 18, 2024

Conversation

kdorheim
Copy link
Contributor

@kdorheim kdorheim commented Jul 1, 2024

Should resolve #743

@ptrscll
Copy link
Collaborator

ptrscll commented Jul 3, 2024

Description:
This pull request updates the output of Hector to correctly report changes in aerosol and volcanic radiative forcing caused by changes in alpha and volscl, resolving #743. This PR should not change the default run output.

Previous Behavior:
As described in #743, changing volscl or alpha does not change any of the volcanic/aerosol radiative forcing values (or the total radiative forcing) output by Hector, despite different radiative forcing values being correctly used in temperature calculations. This PR seeks to resolve this issue.

The graphs below illustrate this issue for runs with different values of alpha/volscl. Note how temperature correctly changes but radiative forcing values remain the same.

old_vary_alpha
old_vary_vol

New Behavior:
Within Hector, volscl and alpha have been switched to inputs to the forcing component rather than inputs to the temperature component. With this change, these parameters now correctly affect the output for their respective radiative forcing values. Note that we make the assumption that alpha uniformly impacts each of the five aerosols’ radiative forcings.

Additionally, there are new unit tests that check to confirm that these two parameters have the expected impacts on their respective radiative forcings.

The graphs below show the new model behavior when varying alpha and volscl.
new_vary_alpha
image

Comparison:

Comparing the data frames from the default run between the dev and alpha_volcl versions of Hector, there was no change in any of the output values for total RF, ocean heat flux, global temperature, or CO2 concentrations. This is reflected in the following plot, which shows that the default runs produce the same results for both Hector versions.

image

When we adjust alpha or volscl, the new runs now reflect those changes in RF values but have identical temperature values. This is expected, since this PR is not meant to change the actual effect of alpha/volscl, just where it’s being applied. Graphs showing this trend are given below:

image

image

@ptrscll ptrscll marked this pull request as ready for review July 3, 2024 21:34
Copy link
Member

@bpbond bpbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely documented and an extremely sensible change! It looks great overall, though a few things to consider below.

inst/include/component_data.hpp Outdated Show resolved Hide resolved
@kdorheim
Copy link
Contributor Author

I guess one question for @bpbond cause this is a code-breaking change it would probably be part of a V4 release... does that mean that it should go into a different dev branch? if we are thinking about doing to another V3 release? But that might be a bigger question about how we want to manage Hector releases and stuff

Copy link

Differences in Hector outputs

Hello, this is leeyabot!

The current pull request's outputs do not differ from 3.1.1 (d931a00).

Copy link

Differences in Hector outputs

Hello, this is leeyabot!

The current pull request's outputs do not differ from 3.1.1 (d931a00).

@ptrscll
Copy link
Collaborator

ptrscll commented Jul 12, 2024

I just pushed two commits to rename alpha to aero_scalar and volscl to vol_scalar as @bpbond suggested.

@JGCRI JGCRI deleted a comment from github-actions bot Jul 15, 2024
@JGCRI JGCRI deleted a comment from github-actions bot Jul 15, 2024
Copy link

Differences in Hector outputs

Hello, this is leeyabot!

The current pull request's outputs do not differ from 3.1.1 (d931a00).

@bpbond bpbond linked an issue Jul 17, 2024 that may be closed by this pull request
@kdorheim kdorheim changed the base branch from dev to dev4 July 18, 2024 01:42
@kdorheim kdorheim merged commit 6b91163 into dev4 Jul 18, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RF scalar effect not reported in respective output
3 participants