Handle nil case for scheduled arrivals #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Return DUE if ETA is 0, add a suffix of min if the value is one, and a suffix of mins if the value is anything else
Handle the case where there are no scheduled arrivals by not showing Direction/Arrival and telling the user 'No planned arrivals'.
JHWelch
requested changes
Feb 10, 2024
There was a problem hiding this comment.
@jmwyds Thanks a bunch for the contribution! Been meaning to add that myself.
Do you mind fixing the linting and test failures? If you're having trouble let me know and I can take a look.
If you could add a add a test for the nil case as well that would be great, but again I can handle that if you can't get it to work.
No problem! I should be able to get to addressing that tomorrow. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Jordan! Love the updates to Nate's module. I was experiencing some issues with the other module since updating my Node version earlier today. Due to these issues, I was worried I'd have to take it off my mirror until I found yours, so thank you for the updates.
As for the reason for this PR, I frequent a bus stop that runs only on weekdays during work hours, so a good amount of time my mirror would show no options for bus ETAs (shown below).
Therefore, I added handling for this case which removes the
Direction/Arrivalheadings and adds a note to the user that there are no planned arrivals.Additionally, I added a suffix of
minorminsrespectively to the arrival times. This isn't a huge deal to me but I figured why not. Feel free to take whatever you want from here or nothing at all. Thanks again!Side note, I also noticed that the table re-renders each time an update interval is reached causing a momentary stutter in the display but that is a fix for another day