Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ktlint to 0.36 #327

Closed

Conversation

friederbluemle
Copy link
Contributor

No description provided.

@nikiJava
Copy link

Please, merge this PR, cause new ktlint version has some important fixes.
pinterest/ktlint#625

@JLLeitschuh
Copy link
Owner

This is causing test failures. Can you look into this?
https://github.com/JLLeitschuh/ktlint-gradle/pull/327/checks?check_run_id=404304250#step:6:73

@friederbluemle
Copy link
Contributor Author

Hi, yeah, I saw the test failure, will try to check later today. Sorry for not responding sooner!

@Tapchicoma
Copy link
Collaborator

@nikiJava you could just set it via extension configuration, check "version" property: https://github.com/JLLeitschuh/ktlint-gradle#configuration

@friederbluemle sorry, ktlint is already updated on master to 0.36.0:

val version: Property<String> = objectFactory.property { set("0.36.0") }

Unfortunately it is not yet published, but it will be soon!

@Tapchicoma Tapchicoma closed this Feb 1, 2020
@friederbluemle
Copy link
Contributor Author

🤦‍♂ Of course.. my bad, sorry about that.

Looking forward to the new version. 👍

@friederbluemle friederbluemle deleted the update-ktlint branch February 1, 2020 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants