Date-issue whatsapp revised 1.0 #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JRavi2
reviewed
Dec 13, 2021
src/chat_analyzer.py
Outdated
Comment on lines
162
to
181
| formatdmy = 1 | ||
| formatmdy = 1 | ||
| formatymd = 1 | ||
| #To check that the date formats in the chat are in which format | ||
| #Can also check the time format here itself... | ||
| for line in f: | ||
| match = re.search(WMsg, line) | ||
| if match: | ||
| try: | ||
| datetime_object = datetime.strptime(match.groupdict()['date'], '%m/%d/%y') | ||
| except: | ||
| formatmdy = 0 | ||
| try: | ||
| datetime_object = datetime.strptime(match.groupdict()['date'], '%d/%m/%y') | ||
| except: | ||
| formatdmy = 0 | ||
| try: | ||
| datetime_object = datetime.strptime(match.groupdict()['date'], '%y/%m/%d') | ||
| except: | ||
| formatymd = 0 |
There was a problem hiding this comment.
So, instead of maintaining three identifiers for the different formats, what we can do is store the varying parameters, namely, datetime_object (already there), month, day, and year.
src/chat_analyzer.py
Outdated
Comment on lines
185
to
195
| if match and formatmdy: | ||
| msgs.append({ | ||
| 'username': match.groupdict()['username'], | ||
| 'date': datetime.strptime(match.groupdict()['date'], '%m/%d/%y').date(), | ||
| 'month': match.groupdict()['month'], | ||
| 'day': match.groupdict()['day'], | ||
| 'year': match.groupdict()['year'], | ||
| 'month': match.groupdict()['feild1'], | ||
| 'day': match.groupdict()['feild2'], | ||
| 'year': match.groupdict()['feild3'], | ||
| 'time': datetime.strptime(match.groupdict()['time'], '%H:%M').time(), | ||
| 'hour': match.groupdict()['hour'], | ||
| 'minute': match.groupdict()['minute'], | ||
| }) |
There was a problem hiding this comment.
Then, here, instead of having the if-else chain, we can just have the one if condition checking if there is a match or not, and if there is a match just use the parameters that were stored earlier.
|
Let me know if more clarification is required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10