-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GitHub quality check action: The starting letters should match #107
Comments
Thanks for your script, I would say column and line number reporting is the best way to go forward. Followed by a manual editing then |
Hi, I've updated the script so that now, it returns all the locations of all escaped ampersands, instead of just failing on the first one found. This has been tested locally with multiple escaped ampersands across multiple files. I have also amended the erroneous csv file. Aside from the small formatting error, I was wondering if this was ready for a code review/draft pull request. I have currently worked on my main branch so as to simulate how GitHub actions will execute the script in actuality, but I can transfer this over to a feature branch if needed. Any other feedback is also appreciated, thanks! |
@AkshatJain9 you implemented "Each abbreviation should not contain &" The check for "the starting letters should match somehow" is still missing. I don't know, how easy this is. |
The action should check:
\&
(refs Fixes and additions #100 (comment))The text was updated successfully, but these errors were encountered: