Checkstyle

JabRef · Mar 10, 2020 · 0db37df · 0db37df
1 parent 85b2af2
commit 0db37df
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 12 deletions.
diff --git a/src/main/java/org/jabref/gui/JabRefFrame.java b/src/main/java/org/jabref/gui/JabRefFrame.java
@@ -146,10 +146,10 @@
  */
 public class JabRefFrame extends BorderPane {
 
-    private static final Logger LOGGER = LoggerFactory.getLogger(JabRefFrame.class);
-
     public static final String FRAME_TITLE = "JabRef";
 
+    private static final Logger LOGGER = LoggerFactory.getLogger(JabRefFrame.class);
+
     private final SplitPane splitPane = new SplitPane();
     private final JabRefPreferences prefs = Globals.prefs;
     private final GlobalSearchBar globalSearchBar = new GlobalSearchBar(this, Globals.stateManager);

diff --git a/src/test/java/org/jabref/architecture/TestArchitectureTests.java b/src/test/java/org/jabref/architecture/TestArchitectureTests.java
@@ -5,7 +5,6 @@
 import java.nio.file.Files;
 import java.nio.file.Path;
 import java.nio.file.Paths;
-import java.util.ArrayList;
 import java.util.Collections;
 import java.util.List;
 import java.util.function.Predicate;

diff --git a/src/test/java/org/jabref/gui/ScreenshotDarkTheme.java b/src/test/java/org/jabref/gui/ScreenshotDarkTheme.java
@@ -34,12 +34,12 @@
 class ScreenshotDarkTheme {
 
     private static final Logger LOGGER = LoggerFactory.getLogger(ScreenshotDarkTheme.class);
-    final static Path root = Path.of("build/screenshots").toAbsolutePath();
+    private static final Path ROOT = Path.of("build/screenshots").toAbsolutePath();
 
     @BeforeAll
     static void createDirectory() throws IOException {
-        if (!Files.exists(root)) {
-            Files.createDirectory(root);
+        if (!Files.exists(ROOT)) {
+            Files.createDirectory(ROOT);
         }
     }
 
@@ -72,7 +72,7 @@ void screenshotOpenedDatabase(FxRobot robot) throws Exception {
         JabRefGUI.getMainFrame().getOpenDatabaseAction().openFile(jabrefAuthorsBib, true);
         // give database some time load
         robot.interrupt(100);
-        DebugUtils.saveScreenshot(() -> root.resolve("opened-database-dark-theme.png"), "").apply(stringBuilder);
+        DebugUtils.saveScreenshot(() -> ROOT.resolve("opened-database-dark-theme.png"), "").apply(stringBuilder);
         LOGGER.debug(stringBuilder.toString());
     }
 }
diff --git a/src/test/java/org/jabref/gui/Screenshots.java b/src/test/java/org/jabref/gui/Screenshots.java
@@ -32,12 +32,12 @@
 class Screenshots {
 
     private static final Logger LOGGER = LoggerFactory.getLogger(Screenshots.class);
-    final static Path root = Path.of("build/screenshots").toAbsolutePath();
+    private static final Path ROOT = Path.of("build/screenshots").toAbsolutePath();
 
     @BeforeAll
     static void createDirectory() throws IOException {
-        if (!Files.exists(root)) {
-            Files.createDirectory(root);
+        if (!Files.exists(ROOT)) {
+            Files.createDirectory(ROOT);
         }
     }
 
@@ -65,7 +65,7 @@ public void onStop() {
     @Order(1)
     void screenshotMainMenu() {
         StringBuilder stringBuilder = new StringBuilder();
-        DebugUtils.saveScreenshot(() -> root.resolve("main-empty.png"), "").apply(stringBuilder);
+        DebugUtils.saveScreenshot(() -> ROOT.resolve("main-empty.png"), "").apply(stringBuilder);
         LOGGER.debug(stringBuilder.toString());
     }
 
@@ -79,7 +79,7 @@ void screenshotOpenedDatabase(FxRobot robot) throws Exception {
         JabRefGUI.getMainFrame().getOpenDatabaseAction().openFile(jabrefAuthorsBib, true);
         // give database some time load
         robot.interrupt(100);
-        DebugUtils.saveScreenshot(() -> root.resolve("opened-database.png"), "").apply(stringBuilder);
+        DebugUtils.saveScreenshot(() -> ROOT.resolve("opened-database.png"), "").apply(stringBuilder);
         LOGGER.debug(stringBuilder.toString());
     }
 }