Skip to content

Commit

Permalink
Exemplified menu entries for change case menu (#9382)
Browse files Browse the repository at this point in the history
* We modified the Change case sub-menus and their corresponding tips (displayed when you stay long over the menu) to properly reflect exemplified cases. [#9339](#9339)

* Use l10n for menu entries string

* fix changelog codestyle issue

* fix test issue

Co-authored-by: manu-vaillant-afk <manu.vaillant@student.hers.be>
  • Loading branch information
manv-afk and manu-vaillant-afk authored Nov 30, 2022
1 parent a572ebb commit 1e3bc02
Show file tree
Hide file tree
Showing 6 changed files with 15 additions and 14 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ Note that this project **does not** adhere to [Semantic Versioning](http://semve
- We added HTML and Markdown files to Find Unlinked Files and removed BibTeX.[koppor#547](https://github.com/koppor/jabref/issues/547)
- We changed the messages after importing unlinked local files to past tense. [koppor#548](https://github.com/koppor/jabref/issues/548)
- We fixed an issue where the wrong icon for a successful import of a bib entry was shown [#9308](https://github.com/JabRef/jabref/pull/9308)
- We modified the Change case sub-menus and their corresponding tips (displayed when you stay long over the menu) to properly reflect exemplified cases. [#9339](https://github.com/Jabref/jabref/issues/9339)

### Fixed

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ public String format(String input) {
@Override
public String getDescription() {
return Localization.lang(
"Changes the first letter of all words to capital case and the remaining letters to lower case.");
"Changes The First Letter Of All Words To Capital Case And The Remaining Letters To Lower Case.");
}

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ public class LowerCaseFormatter extends Formatter {

@Override
public String getName() {
return Localization.lang("Lower case");
return Localization.lang("lower case");
}

@Override
Expand All @@ -29,7 +29,7 @@ public String format(String input) {

@Override
public String getDescription() {
return Localization.lang("Changes all letters to lower case.");
return Localization.lang("changes all letters to lower case.");
}

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ public class TitleCaseFormatter extends Formatter {

@Override
public String getName() {
return Localization.lang("Title case");
return Localization.lang("Title Case");
}

@Override
Expand Down Expand Up @@ -50,7 +50,7 @@ public String format(String input) {
@Override
public String getDescription() {
return Localization.lang(
"Capitalize all words, but converts articles, prepositions, and conjunctions to lower case.");
"Capitalize all Words, but Converts Articles, Prepositions, and Conjunctions to Lower Case.");
}

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ public class UpperCaseFormatter extends Formatter {

@Override
public String getName() {
return Localization.lang("Upper case");
return Localization.lang("UPPER CASE");
}

@Override
Expand All @@ -30,7 +30,7 @@ public String format(String input) {
@Override
public String getDescription() {
return Localization.lang(
"Changes all letters to upper case.");
"CHANGES ALL LETTER TO UPPER CASE.");
}

@Override
Expand Down
14 changes: 7 additions & 7 deletions src/main/resources/l10n/JabRef_en.properties
Original file line number Diff line number Diff line change
Expand Up @@ -1453,11 +1453,11 @@ Invalid\ style\ selected=Invalid style selected
Reload=Reload

Capitalize=Capitalize
Capitalize\ all\ words,\ but\ converts\ articles,\ prepositions,\ and\ conjunctions\ to\ lower\ case.=Capitalize all words, but converts articles, prepositions, and conjunctions to lower case.
Capitalize\ all\ Words,\ but\ Converts\ Articles,\ Prepositions,\ and\ Conjunctions\ to\ Lower\ Case.=Capitalize all Words, but Converts Articles, Prepositions, and Conjunctions to Lower Case.
Capitalize\ the\ first\ word,\ changes\ other\ words\ to\ lower\ case.=Capitalize the first word, changes other words to lower case.
Changes\ all\ letters\ to\ lower\ case.=Changes all letters to lower case.
Changes\ all\ letters\ to\ upper\ case.=Changes all letters to upper case.
Changes\ the\ first\ letter\ of\ all\ words\ to\ capital\ case\ and\ the\ remaining\ letters\ to\ lower\ case.=Changes the first letter of all words to capital case and the remaining letters to lower case.
changes\ all\ letters\ to\ lower\ case.=changes all letters to lower case.
CHANGES\ ALL\ LETTER\ TO\ UPPER\ CASE.=CHANGES ALL LETTER TO UPPER CASE.
Changes\ The\ First\ Letter\ Of\ All\ Words\ To\ Capital\ Case\ And\ The\ Remaining\ Letters\ To\ Lower\ Case.=Changes The First Letter Of All Words To Capital Case And The Remaining Letters To Lower Case.
Cleans\ up\ LaTeX\ code.=Cleans up LaTeX code.
Converts\ HTML\ code\ to\ LaTeX\ code.=Converts HTML code to LaTeX code.
HTML\ to\ Unicode=HTML to Unicode
Expand All @@ -1469,7 +1469,7 @@ Converts\ units\ to\ LaTeX\ formatting.=Converts units to LaTeX formatting.
HTML\ to\ LaTeX=HTML to LaTeX
LaTeX\ cleanup=LaTeX cleanup
LaTeX\ to\ Unicode=LaTeX to Unicode
Lower\ case=Lower case
lower\ case=lower case
Minify\ list\ of\ person\ names=Minify list of person names
Normalize\ date=Normalize date
Normalize\ en\ dashes=Normalize en dashes
Expand All @@ -1492,10 +1492,10 @@ Shorten\ DOI=Shorten DOI
Shortens\ DOI\ to\ more\ human\ readable\ form.=Shortens DOI to more human readable form.
Sentence\ case=Sentence case
Shortens\ lists\ of\ persons\ if\ there\ are\ more\ than\ 2\ persons\ to\ "et\ al.".=Shortens lists of persons if there are more than 2 persons to "et al.".
Title\ case=Title case
Title\ Case=Title Case
Unicode\ to\ LaTeX=Unicode to LaTeX
Units\ to\ LaTeX=Units to LaTeX
Upper\ case=Upper case
UPPER\ CASE=UPPER CASE
Does\ nothing.=Does nothing.
Identity=Identity
Clears\ the\ field\ completely.=Clears the field completely.
Expand Down

0 comments on commit 1e3bc02

Please sign in to comment.