Refine NoBibtexFieldChecker to treat more biblatex-only fields

CHANGELOG.md

@@ -24,6 +24,7 @@ We refer to [GitHub issues](https://github.com/JabRef/jabref/issues) by using `#
 - We changed the order of the cleanup operations so that the generated file name corresponds to the cleaned-up fields. [1441](https://github.com/JabRef/jabref/issues/1441)
 - Replaces manual thread management with cached thread pool
 - We replaced the field name `journaltitle` by `journal` in BibLaTeX-mode as `journaltitle` was causing headaches [#2209](https://github.com/JabRef/jabref/issues/2209)
+- We enhanced the integrity checks testing for biblatex-only fields to be aware of more fields (e.g., `location`).
 - Files can now be moved to subfolders named by a custom format pattern, e.g., based on `entrytype`.
   The pattern can be specified in the settings like the filename pattern. [#1092](https://github.com/JabRef/jabref/issues/1092)
 

src/main/java/net/sf/jabref/logic/integrity/NoBibtexFieldChecker.java

@@ -1,31 +1,35 @@
 package net.sf.jabref.logic.integrity;
 
-import java.util.Collections;
+import java.util.ArrayList;
 import java.util.List;
-import java.util.Optional;
+import java.util.SortedSet;
+import java.util.TreeSet;
+import java.util.stream.Collectors;
 
 import net.sf.jabref.logic.integrity.IntegrityCheck.Checker;
 import net.sf.jabref.logic.l10n.Localization;
 import net.sf.jabref.model.entry.BibEntry;
+import net.sf.jabref.model.entry.EntryConverter;
 import net.sf.jabref.model.entry.FieldName;
 
 public class NoBibtexFieldChecker implements Checker {
 
-    /**
-     * BibLaTeX package documentation (Section 2.1.1):
-     * The title of the periodical is given in the journaltitle field.
-     */
     @Override
     public List<IntegrityMessage> check(BibEntry entry) {
-        Optional<String> value = entry.getField(FieldName.JOURNALTITLE);
-
-        //BibTeX
-        if (!value.isPresent()) {
-            return Collections.emptyList();
-        }
-        else {
-            return Collections.singletonList(
-                    new IntegrityMessage(Localization.lang("BibLaTeX field only"), entry, FieldName.JOURNALTITLE));
-        }
+        SortedSet<String> allBibLaTeXOnlyFields = new TreeSet<>();
+        allBibLaTeXOnlyFields.addAll(EntryConverter.FIELD_ALIASES_LTX_TO_TEX.keySet());
+
+        // file is both in bibtex and biblatex
+        allBibLaTeXOnlyFields.remove(FieldName.FILE);
+
+        // these two are in BibLaTeX only
+        allBibLaTeXOnlyFields.add(FieldName.JOURNALTITLE);
+        allBibLaTeXOnlyFields.add(FieldName.JOURNALSUBTITLE);
+
+        List<IntegrityMessage> res = new ArrayList<>();
+        return entry.getFieldNames().stream()
+                .filter(name ->  allBibLaTeXOnlyFields.contains(name))
+                .map(name -> new IntegrityMessage(Localization.lang("BibLaTeX field only"), entry, name)).collect(Collectors.toList());
     }
+
 }