fix checkstyle

JabRef · Sep 26, 2020 · 3ea16a6 · 3ea16a6
1 parent 0aba233
commit 3ea16a6
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 11 deletions.
diff --git a/src/main/java/org/jabref/gui/JabRefFrame.java b/src/main/java/org/jabref/gui/JabRefFrame.java
@@ -1148,6 +1148,7 @@ public void addTab(BasePanel basePanel, boolean raisePanel) {
         basePanel.getUndoManager().registerListener(new UndoRedoEventManager());
 
         BibDatabaseContext context = basePanel.getBibDatabaseContext();
+        GlobalSaveManager manager = GlobalSaveManager.create(basePanel, prefs, Globals.entryTypesManager);
 
         if (readyForAutosave(context)) {
             AutosaveManager autosaver = AutosaveManager.start(context);

diff --git a/src/main/java/org/jabref/gui/dialogs/AutosaveUiManager.java b/src/main/java/org/jabref/gui/dialogs/AutosaveUiManager.java
@@ -14,6 +14,7 @@
  * the given {@link BasePanel}.
  */
 public class AutosaveUiManager {
+
     private static final Logger LOGGER = LoggerFactory.getLogger(AutosaveUiManager.class);
 
     private final BasePanel panel;
@@ -25,7 +26,7 @@ public AutosaveUiManager(BasePanel panel) {
     @Subscribe
     public void listen(@SuppressWarnings("unused") AutosaveEvent event) {
         try {
-            SaveDatabaseAction saveAction =  new SaveDatabaseAction(panel, Globals.prefs, Globals.entryTypesManager);
+            SaveDatabaseAction saveAction = new SaveDatabaseAction(panel, Globals.prefs, Globals.entryTypesManager);
             saveAction.save(SaveDatabaseAction.SaveDatabaseMode.SILENT);
         } catch (Throwable e) {
             LOGGER.error("Problem occurred while saving.", e);

diff --git a/src/main/java/org/jabref/gui/exporter/SaveDatabaseAction.java b/src/main/java/org/jabref/gui/exporter/SaveDatabaseAction.java
@@ -2,7 +2,6 @@
 
 import java.nio.charset.Charset;
 import java.nio.file.Path;
-import java.util.HashSet;
 import java.util.List;
 import java.util.Optional;
 import java.util.Set;
@@ -51,7 +50,6 @@
 public class SaveDatabaseAction {
 
     private static final Logger LOGGER = LoggerFactory.getLogger(SaveDatabaseAction.class);
-    private static Set<SaveDatabaseAction> runningInstances = new HashSet<>();
 
     private final BasePanel panel;
     private final JabRefFrame frame;
@@ -218,8 +216,8 @@ private boolean save(Path targetPath, SaveDatabaseMode mode) {
     }
 
     private boolean saveDatabase(Path file, boolean selectedOnly, Charset encoding, SavePreferences.DatabaseSaveType saveType) throws SaveException {
-
         GlobalSaveManager manager = GlobalSaveManager.create(panel, preferences, entryTypesManager);
+
         SavePreferences preferences = this.preferences.getSavePreferences()
                                                       .withEncoding(encoding)
                                                       .withSaveType(saveType);
@@ -229,7 +227,7 @@ private boolean saveDatabase(Path file, boolean selectedOnly, Charset encoding,
         var future = manager.save(file, selectedOnly, encoding, saveType, panel.getBibDatabaseContext(), consumer);
         Set<Character> characters;
         try {
-            characters =future.get();
+            characters = future.get();
             if (!characters.isEmpty()) {
                 saveWithDifferentEncoding(file, selectedOnly, preferences.getEncoding(), characters, saveType);
             }
@@ -242,7 +240,6 @@ private boolean saveDatabase(Path file, boolean selectedOnly, Charset encoding,
 
     }
 
-
     private void saveWithDifferentEncoding(Path file, boolean selectedOnly, Charset encoding, Set<Character> encodingProblems, SavePreferences.DatabaseSaveType saveType) throws SaveException {
         DialogPane pane = new DialogPane();
         VBox vbox = new VBox();
@@ -271,10 +268,10 @@ private void saveWithDifferentEncoding(Path file, boolean selectedOnly, Charset
 
     private boolean readyForAutosave(BibDatabaseContext context) {
         return ((context.getLocation() == DatabaseLocation.SHARED) ||
-                        ((context.getLocation() == DatabaseLocation.LOCAL)
-                                        && preferences.getBoolean(JabRefPreferences.LOCAL_AUTO_SAVE)))
-                        &&
-                        context.getDatabasePath().isPresent();
+                ((context.getLocation() == DatabaseLocation.LOCAL)
+                 && preferences.getBoolean(JabRefPreferences.LOCAL_AUTO_SAVE)))
+               &&
+               context.getDatabasePath().isPresent();
     }
 
     private boolean readyForBackup(BibDatabaseContext context) {

diff --git a/src/main/java/org/jabref/logic/exporter/GlobalSaveManager.java b/src/main/java/org/jabref/logic/exporter/GlobalSaveManager.java
@@ -54,7 +54,7 @@ private void shutdown() {
 
     }
 
-    public Future<Set<Character>> save(Path file, boolean selectedOnly, Charset encoding, SavePreferences.DatabaseSaveType saveType, BibDatabaseContext context, Consumer<List<FieldChange>> consumeFieldChanges) throws SaveException {
+    public Future<Set<Character>> save(Path file, boolean selectedOnly, Charset encoding, SavePreferences.DatabaseSaveType saveType, BibDatabaseContext context, Consumer<List<FieldChange>> consumeFieldChanges) {
         return throttler.scheduleTask(() -> saveThrotteld(file, selectedOnly, encoding, saveType, context, consumeFieldChanges));
     }