-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge branch 'main' into fix-for-issue-9840
- Loading branch information
Showing
12 changed files
with
223 additions
and
16 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,76 @@ | ||
| package org.jabref.logic.cleanup; | ||
|
|
||
| import java.util.ArrayList; | ||
| import java.util.List; | ||
| import java.util.regex.Matcher; | ||
| import java.util.regex.Pattern; | ||
|
|
||
| import org.jabref.model.FieldChange; | ||
| import org.jabref.model.entry.BibEntry; | ||
| import org.jabref.model.entry.field.Field; | ||
| import org.jabref.model.entry.field.StandardField; | ||
|
|
||
| /** | ||
| * Checks whether URL exists in note field, and stores it under url field. | ||
| */ | ||
| public class URLCleanup implements CleanupJob { | ||
|
|
||
| private static final Field NOTE_FIELD = StandardField.NOTE; | ||
| private static final Field URL_FIELD = StandardField.URL; | ||
|
|
||
| @Override | ||
| public List<FieldChange> cleanup(BibEntry entry) { | ||
| List<FieldChange> changes = new ArrayList<>(); | ||
|
|
||
| String noteFieldValue = entry.getField(NOTE_FIELD).orElse(null); | ||
|
|
||
| /* | ||
| * The urlRegex was originally fetched from a suggested solution in | ||
| * https://stackoverflow.com/questions/28185064/python-infinite-loop-in-regex-to-match-url. | ||
| * In order to be functional, we made the necessary adjustments regarding Java | ||
| * features (mainly doubled backslashes). | ||
| */ | ||
| String urlRegex = "(?i)\\b((?:https?://|www\\d{0,3}[.]|[a-z0-9.\\-]+[.]" | ||
| + "[a-z]{2,4}/)(?:[^\\s()<>\\\\]+|\\(([^\\s()<>\\\\]+|(\\([^\\s()" | ||
| + "<>\\\\]+\\)))*\\))+(?:\\(([^\\s()<>\\\\]+|(\\([^\\s()<>\\\\]+\\" | ||
| + ")))*\\)|[^\\s`!()\\[\\]{};:'\".,<>?«»“”‘’]))"; | ||
|
|
||
| final Pattern pattern = Pattern.compile(urlRegex, Pattern.CASE_INSENSITIVE); | ||
| final Matcher matcher = pattern.matcher(noteFieldValue); | ||
|
|
||
| if (matcher.find()) { | ||
| String url = matcher.group(); | ||
|
|
||
| // Remove the URL from the NoteFieldValue | ||
| String newNoteFieldValue = noteFieldValue | ||
| .replace(url, "") | ||
|
|
||
| /* | ||
| * The following regex erases unnecessary remaining | ||
| * content in note field. Explanation: | ||
| * <ul> | ||
| * <li>"(, )?": Matches an optional comma followed by a space</li> | ||
| * <li>"\\?": Matches an optional backslash</li> | ||
| * <li>"url\{\}": Matches the literal string "url{}"</li> | ||
| * </ul> | ||
| * Note that the backslashes are doubled as Java requirement | ||
| */ | ||
| .replaceAll("(, )?\\\\?url\\{\\}(, )?", ""); | ||
|
|
||
| /* | ||
| * In case the url and note fields hold the same URL, then we just | ||
| * remove it from the note field, and no other action is performed. | ||
| */ | ||
| if (entry.hasField(URL_FIELD)) { | ||
| String urlFieldValue = entry.getField(URL_FIELD).orElse(null); | ||
| if (urlFieldValue.equals(url)) { | ||
| entry.setField(NOTE_FIELD, newNoteFieldValue).ifPresent(changes::add); | ||
| } | ||
| } else { | ||
| entry.setField(NOTE_FIELD, newNoteFieldValue).ifPresent(changes::add); | ||
| entry.setField(URL_FIELD, url).ifPresent(changes::add); | ||
| } | ||
| } | ||
| return changes; | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.