Skip to content

Commit

Permalink
Revert "Replace "year" by "date" as the fields returned are biblatex …
Browse files Browse the repository at this point in the history
…fields"

This reverts commit b2c8db5.
  • Loading branch information
simonharrer committed Apr 5, 2016
1 parent 23ec6a9 commit 93fdb02
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 10 deletions.
15 changes: 8 additions & 7 deletions src/main/java/net/sf/jabref/importer/fetcher/GVKParser.java
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ private BibEntry parseEntry(Element e) {
String editor = null;
String title = null;
String publisher = null;
String date = null;
String year = null;
String address = null;
String series = null;
String edition = null;
Expand Down Expand Up @@ -162,14 +162,15 @@ private BibEntry parseEntry(Element e) {
address = getSubfield("p", datafield);
}

//date

This comment has been minimized.

Copy link
@tobiasdiez

tobiasdiez Apr 5, 2016

Member

We spoke about the topic in the last devcall and came to the conclusion that fetchers preferably should return BibLaTeX entries. Afterwards a cleanup operation can convert these (automatically) to BibTeX depending on the database mode.

This comment has been minimized.

Copy link
@simonharrer

simonharrer Apr 5, 2016

Author Contributor

Stefan told me the quick decision was to revert this commit. Maybe I misunderstood something? @stefan-kolb

This comment has been minimized.

Copy link
@koppor

koppor Apr 7, 2016

Member

Yes, it was the quick decision.

The long-term solution would be to support the biblatex to bibtex conversion. However, this is not yet implemented. And the GVK fetcher is the only fetcher returning biblatex. Maybe, we have to rewrite that fetcher?

Refs #447

//year
if ("011@".equals(tag)) {
date = getSubfield("a", datafield);
year = getSubfield("a", datafield);
}

//date, volume, number, pages (year bei Zeitschriften (evtl. redundant mit 011@))
//year, volume, number, pages (year bei Zeitschriften (evtl. redundant mit 011@))
if ("031A".equals(tag)) {
date = getSubfield("j", datafield);
year = getSubfield("j", datafield);

volume = getSubfield("e", datafield);
number = getSubfield("a", datafield);
pages = getSubfield("h", datafield);
Expand Down Expand Up @@ -387,8 +388,8 @@ private BibEntry parseEntry(Element e) {
if (publisher != null) {
result.setField("publisher", publisher);
}
if (date != null) {
result.setField("date", date);
if (year != null) {
result.setField("year", year);
}
if (address != null) {
result.setField("address", address);
Expand Down
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
@Book{,
Title = {GMP-Regelwerke für Arzneimittel},
Publisher = {Maas & Peither, GMP-Verl.},
Year = {2014},
Address = {Schopfheim},
Edition = {7., aktualisierte Aufl.},
Note = {Text teilw. dt., teilw. engl.},
Number = {7},
Series = {Kleiner GMP-Berater},
Date = {2014},
ISBN = {9783943267914},
Pagetotal = {310},
Ppn_GVK = {785759913}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
@Book{,
Title = {GMP-Regelwerke für computergestützte Systeme},
Publisher = {Maas & Peither, GMP-Verl},
Year = {2014},
Address = {Schopfheim},
Edition = {4., aktual. Aufl.},
Note = {Text teilw. dt. und engl},
Number = {Bd. 5},
Series = {Kleiner GMP-Berater},
Date = {2014},
ISBN = {9783958070011},
Pagetotal = {142},
Ppn_GVK = {810635399}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
@Book{,
Title = {GMP-Berater},
Publisher = {Maas und Peither GMP Verl.},
Year = {2014},
Address = {Schopfheim},
Number = {L - N},
Volume = {Bd. I},
Date = {2014},
Editor = {Anita Maas},
Pagetotal = {Losebl.-Ausg.},
Ppn_GVK = {797485368},
Expand Down

0 comments on commit 93fdb02

Please sign in to comment.