-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Revert "Replace "year" by "date" as the fields returned are biblatex …
…fields" This reverts commit b2c8db5.
- Loading branch information
1 parent
23ec6a9
commit 93fdb02
Showing
4 changed files
with
11 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -70,7 +70,7 @@ private BibEntry parseEntry(Element e) { | |
String editor = null; | ||
String title = null; | ||
String publisher = null; | ||
String date = null; | ||
String year = null; | ||
String address = null; | ||
String series = null; | ||
String edition = null; | ||
|
@@ -162,14 +162,15 @@ private BibEntry parseEntry(Element e) { | |
address = getSubfield("p", datafield); | ||
} | ||
|
||
//date | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
simonharrer
Author
Contributor
|
||
//year | ||
if ("011@".equals(tag)) { | ||
date = getSubfield("a", datafield); | ||
year = getSubfield("a", datafield); | ||
} | ||
|
||
//date, volume, number, pages (year bei Zeitschriften (evtl. redundant mit 011@)) | ||
//year, volume, number, pages (year bei Zeitschriften (evtl. redundant mit 011@)) | ||
if ("031A".equals(tag)) { | ||
date = getSubfield("j", datafield); | ||
year = getSubfield("j", datafield); | ||
|
||
volume = getSubfield("e", datafield); | ||
number = getSubfield("a", datafield); | ||
pages = getSubfield("h", datafield); | ||
|
@@ -387,8 +388,8 @@ private BibEntry parseEntry(Element e) { | |
if (publisher != null) { | ||
result.setField("publisher", publisher); | ||
} | ||
if (date != null) { | ||
result.setField("date", date); | ||
if (year != null) { | ||
result.setField("year", year); | ||
} | ||
if (address != null) { | ||
result.setField("address", address); | ||
|
2 changes: 1 addition & 1 deletion
2
src/test/resources/net/sf/jabref/importer/fetcher/gvk_gmp.1.bib
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
src/test/resources/net/sf/jabref/importer/fetcher/gvk_gmp.2.bib
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
src/test/resources/net/sf/jabref/importer/fetcher/gvk_result_for_797485368.bib
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We spoke about the topic in the last devcall and came to the conclusion that fetchers preferably should return BibLaTeX entries. Afterwards a cleanup operation can convert these (automatically) to BibTeX depending on the database mode.