Identify illegal reflective access

JabRef · May 15, 2018 · bcfde56 · bcfde56
1 parent 1c8d38a
commit bcfde56
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 0 deletions.
diff --git a/src/main/java/org/jabref/gui/GUIGlobals.java b/src/main/java/org/jabref/gui/GUIGlobals.java
@@ -65,6 +65,7 @@ public static void init() {
         // Set WM_CLASS using reflection for certain Un*x window managers
         if (!OS.WINDOWS && !OS.OS_X) {
             try {
+                // TODO: reflective access, should be removed (Java 9)
                 Toolkit xToolkit = Toolkit.getDefaultToolkit();
                 java.lang.reflect.Field awtAppClassNameField = xToolkit.getClass().getDeclaredField("awtAppClassName");
                 awtAppClassNameField.setAccessible(true);

diff --git a/src/main/java/org/jabref/gui/groups/GroupTreeView.java b/src/main/java/org/jabref/gui/groups/GroupTreeView.java
@@ -354,6 +354,7 @@ public void addNewGroup(ActionEvent actionEvent) {
      */
     private void setupClearButtonField(CustomTextField customTextField) {
         try {
+            // TODO: reflective access, should be removed (Java 9)
             Method m = TextFields.class.getDeclaredMethod("setupClearButtonField", TextField.class,
                     ObjectProperty.class);
             m.setAccessible(true);

diff --git a/src/main/java/org/jabref/gui/maintable/SmartConstrainedResizePolicy.java b/src/main/java/org/jabref/gui/maintable/SmartConstrainedResizePolicy.java
@@ -53,6 +53,7 @@ private Boolean initColumnSize(TableView<?> table) {
     private void resize(TableColumnBase column, double delta) {
         // We have to use reflection since TableUtil is not visible to us
         try {
+            // TODO: reflective access, should be removed (Java 9)
             Class<?> clazz = Class.forName("javafx.scene.control.TableUtil");
             Method constrainedResize = clazz.getDeclaredMethod("resize", TableColumnBase.class, double.class);
             constrainedResize.setAccessible(true);
@@ -74,6 +75,7 @@ private Boolean constrainedResize(TableView.ResizeFeatures<?> prop) {
     private Boolean constrainedResize(TableView.ResizeFeatures prop, Boolean isFirstRun, Double contentWidth, List<? extends TableColumnBase<?, ?>> visibleLeafColumns) {
         // We have to use reflection since TableUtil is not visible to us
         try {
+            // TODO: reflective access, should be removed (Java 9)
             Class<?> clazz = Class.forName("javafx.scene.control.TableUtil");
             Method constrainedResize = clazz.getDeclaredMethod("constrainedResize", ResizeFeaturesBase.class, Boolean.TYPE, Double.TYPE, List.class);
             constrainedResize.setAccessible(true);
@@ -87,6 +89,7 @@ private Boolean constrainedResize(TableView.ResizeFeatures prop, Boolean isFirst
 
     private Double getContentWidth(TableView<?> table) {
         try {
+            // TODO: reflective access, should be removed (Java 9)
             Field privateStringField = TableView.class.getDeclaredField("contentWidth");
             privateStringField.setAccessible(true);
             return (Double) privateStringField.get(table);

diff --git a/src/main/java/org/jabref/gui/search/GlobalSearchBar.java b/src/main/java/org/jabref/gui/search/GlobalSearchBar.java
@@ -361,6 +361,7 @@ public void setAutoCompleter(AutoCompleteSuggestionProvider<Author> searchComple
     @SuppressWarnings("unchecked")
     private <T> AutoCompletePopup<T> getPopup(AutoCompletionBinding<T> autoCompletionBinding) {
         try {
+            // TODO: reflective access, should be removed (Java 9)
             Field privatePopup = AutoCompletionBinding.class.getDeclaredField("autoCompletionPopup");
             privatePopup.setAccessible(true);
             return (AutoCompletePopup<T>) privatePopup.get(autoCompletionBinding);