Fix multiple entries allowed in crossref (issue #5284) (#5724)

Co-authored-by: Julien Bénard
Co-authored-by: Lucas Beretti
Co-authored-by: Venceslas Roullier

CHANGELOG.md

@@ -64,6 +64,7 @@ We refer to [GitHub issues](https://github.com/JabRef/jabref/issues) by using `#
 - We fixed an exception which occurred when an invalid jstyle was loaded. [#5452](https://github.com/JabRef/jabref/issues/5452)
 - We fixed an issue where the command line arguments `importBibtex` and `importToOpen` did not import into the currently open library, but opened a new one. [#5537](https://github.com/JabRef/jabref/issues/5537)
 - We fixed an error where the preview theme did not adapt to the "Dark" mode [#5463](https://github.com/JabRef/jabref/issues/5463)
+- We fixed an issue where multiple entries were allowed in the "crossref" field [#5284](https://github.com/JabRef/jabref/issues/5284)
 - We fixed an issue where the merge dialog showed the wrong text colour in "Dark" mode [#5516](https://github.com/JabRef/jabref/issues/5516)
 - We fixed visibility issues with the scrollbar and group selection highlight in "Dark" mode, and enabled "Dark" mode for the OpenOffice preview in the style selection window. [#5522](https://github.com/JabRef/jabref/issues/5522)
 - We fixed an issue where the author field was not correctly parsed during bibtex key-generation. [#5551](https://github.com/JabRef/jabref/issues/5551)

src/main/java/org/jabref/gui/fieldeditors/FieldEditors.java

@@ -84,7 +84,9 @@ public static FieldEditorFX getForField(final Field field,
             } else {
                 return new OptionEditor<>(new TypeEditorViewModel(field, suggestionProvider, fieldCheckers));
             }
-        } else if (fieldProperties.contains(FieldProperty.SINGLE_ENTRY_LINK) || fieldProperties.contains(FieldProperty.MULTIPLE_ENTRY_LINK)) {
+        } else if (fieldProperties.contains(FieldProperty.SINGLE_ENTRY_LINK)) {
+            return new LinkedEntriesEditor(field, databaseContext, suggestionProvider, fieldCheckers);
+        } else if (fieldProperties.contains(FieldProperty.MULTIPLE_ENTRY_LINK)) {
             return new LinkedEntriesEditor(field, databaseContext, suggestionProvider, fieldCheckers);
         } else if (fieldProperties.contains(FieldProperty.PERSON_NAMES)) {
             return new PersonsEditor(field, suggestionProvider, preferences, fieldCheckers, isSingleLine);

src/main/java/org/jabref/gui/fieldeditors/LinkedEntriesEditor.java

@@ -18,16 +18,19 @@
 
 public class LinkedEntriesEditor extends HBox implements FieldEditorFX {
 
-    @FXML private final LinkedEntriesEditorViewModel viewModel;
-    @FXML private TagBar<ParsedEntryLink> linkedEntriesBar;
+    @FXML
+    private final LinkedEntriesEditorViewModel viewModel;
+    @FXML
+    private TagBar<ParsedEntryLink> linkedEntriesBar;
 
     public LinkedEntriesEditor(Field field, BibDatabaseContext databaseContext, AutoCompleteSuggestionProvider<?> suggestionProvider, FieldCheckers fieldCheckers) {
         this.viewModel = new LinkedEntriesEditorViewModel(field, suggestionProvider, databaseContext, fieldCheckers);
 
         ViewLoader.view(this)
-                  .root(this)
-                  .load();
+                .root(this)
+                .load();
 
+        linkedEntriesBar.setFieldProperties(field.getProperties());
         linkedEntriesBar.setStringConverter(viewModel.getStringConverter());
         linkedEntriesBar.setOnTagClicked((parsedEntryLink, mouseEvent) -> viewModel.jumpToEntry(parsedEntryLink));
 

src/main/java/org/jabref/gui/util/component/TagBar.java

@@ -2,6 +2,7 @@
 
 import java.util.Collection;
 import java.util.function.BiConsumer;
+import java.util.Set;
 import java.util.stream.Collectors;
 
 import javafx.beans.property.ListProperty;
@@ -16,6 +17,7 @@
 import javafx.scene.layout.HBox;
 import javafx.util.StringConverter;
 
+import org.jabref.model.entry.field.FieldProperty;
 import org.jabref.model.strings.StringUtil;
 
 import com.airhacks.afterburner.views.ViewLoader;
@@ -27,18 +29,21 @@ public class TagBar<T> extends HBox {
 
     private final ListProperty<T> tags;
     private StringConverter<T> stringConverter;
-    @FXML private TextField inputTextField;
-    @FXML private HBox tagList;
+    @FXML
+    private TextField inputTextField;
+    @FXML
+    private HBox tagList;
     private BiConsumer<T, MouseEvent> onTagClicked;
+    private java.util.Set<FieldProperty> properties;
 
     public TagBar() {
         tags = new SimpleListProperty<>(FXCollections.observableArrayList());
         tags.addListener(this::onTagsChanged);
 
         // Load FXML
         ViewLoader.view(this)
-                  .root(this)
-                  .load();
+                .root(this)
+                .load();
         getStylesheets().add(0, TagBar.class.getResource("TagBar.css").toExternalForm());
     }
 
@@ -66,6 +71,9 @@ private void onTagsChanged(ListChangeListener.Change<? extends T> change) {
                 tagList.getChildren().addAll(change.getFrom(), change.getAddedSubList().stream().map(this::createTag).collect(Collectors.toList()));
             }
         }
+        if (this.properties.contains(FieldProperty.SINGLE_ENTRY_LINK)) {
+            inputTextField.setDisable(!tags.isEmpty());
+        }
     }
 
     private Tag<T> createTag(T item) {
@@ -83,7 +91,7 @@ private void addTextAsNewTag(ActionEvent event) {
         String inputText = inputTextField.getText();
         if (StringUtil.isNotBlank(inputText)) {
             T newTag = stringConverter.fromString(inputText);
-            if ((newTag != null) && !tags.contains(newTag)) {
+            if ((newTag != null) && !tags.contains(newTag) && (tags.isEmpty() || this.properties.contains(FieldProperty.MULTIPLE_ENTRY_LINK))) {
                 tags.add(newTag);
                 inputTextField.clear();
             }
@@ -97,4 +105,8 @@ public void setStringConverter(StringConverter<T> stringConverter) {
     public void setOnTagClicked(BiConsumer<T, MouseEvent> onTagClicked) {
         this.onTagClicked = onTagClicked;
     }
+
+    public void setFieldProperties(Set<FieldProperty> properties) {
+        this.properties = properties;
+    }
 }