(fix) #2 proxy-password popup now only triggers if both proxy and aut…

…hentication are enabled, before only auth was checked
JabRef · Mar 6, 2023 · cb3cac3 · cb3cac3
1 parent 828110f
commit cb3cac3
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/main/java/org/jabref/gui/JabRefGUI.java b/src/main/java/org/jabref/gui/JabRefGUI.java
@@ -64,7 +64,7 @@ public JabRefGUI(Stage mainStage, List<ParserResult> databases, boolean isBlank,
                 preferencesService.getInternalPreferences())
                 .checkForNewVersionDelayed();
 
-        if (preferencesService.getProxyPreferences().shouldUseAuthentication()){
+        if (preferencesService.getProxyPreferences().shouldUseProxy() && preferencesService.getProxyPreferences().shouldUseAuthentication()){
             DialogService dialogService = Injector.instantiateModelOrService(DialogService.class);
             dialogService.showPasswordDialogAndWait("Proxy configuration", "Proxy requires password","Password")
                 .ifPresent(newPassword -> {