Fix code issues

JabRef · Mar 6, 2017 · d2784ff · d2784ff
1 parent 6514281
commit d2784ff
Show file tree

Hide file tree

Showing 20 changed files with 24 additions and 7 deletions.
diff --git a/src/main/java/org/jabref/gui/IconTheme.java b/src/main/java/org/jabref/gui/IconTheme.java
@@ -32,8 +32,9 @@
 
 public class IconTheme {
 
-    /* Colors */
-    // JabRef's default colors
+    /**
+     * JabRef's default color
+     */
     public static final Color DEFAULT_COLOR = JabRefPreferences.getInstance().getColor(JabRefPreferences.ICON_ENABLED_COLOR);
     public static final Color DEFAULT_DISABLED_COLOR = JabRefPreferences.getInstance().getColor(JabRefPreferences.ICON_DISABLED_COLOR);
     private static final String DEFAULT_ICON_PATH = "/images/external/red.png";
@@ -45,8 +46,8 @@ public class IconTheme {
     // Christmas edition
     //public static final Color DEFAULT_COLOR = new Color(0x155115);
     //public static final Color DEFAULT_DISABLED_COLOR = new Color(0x990000);
-    public static Font FONT_16;
-    public static javafx.scene.text.Font FX_FONT;
+    private static Font FONT_16;
+    private static javafx.scene.text.Font FX_FONT;
 
     static {
         try (InputStream stream = FontBasedIcon.class.getResourceAsStream("/fonts/materialdesignicons-webfont.ttf")) {

diff --git a/src/main/java/org/jabref/logic/groups/DefaultGroupsFactory.java b/src/main/java/org/jabref/logic/groups/DefaultGroupsFactory.java
@@ -1,13 +1,13 @@
 package org.jabref.logic.groups;
 
-import org.jabref.gui.IconTheme;
 import org.jabref.logic.l10n.Localization;
 import org.jabref.model.groups.AllEntriesGroup;
 
 public class DefaultGroupsFactory {
+
     public static AllEntriesGroup getAllEntriesGroup() {
         AllEntriesGroup group = new AllEntriesGroup(Localization.lang("All entries"));
-        group.setIconCode(IconTheme.JabRefIcon.ALL_ENTRIES_GROUP_ICON.getCode());
+        group.setIconCode(org.jabref.gui.IconTheme.JabRefIcon.ALL_ENTRIES_GROUP_ICON.getCode());
         return group;
     }
 }
diff --git a/src/main/java/org/jabref/logic/importer/util/GroupsParser.java b/src/main/java/org/jabref/logic/importer/util/GroupsParser.java
@@ -8,7 +8,6 @@
 import org.jabref.logic.util.MetadataSerializationConfiguration;
 import org.jabref.logic.util.strings.QuotedStringTokenizer;
 import org.jabref.model.groups.AbstractGroup;
-import org.jabref.model.groups.AllEntriesGroup;
 import org.jabref.model.groups.ExplicitGroup;
 import org.jabref.model.groups.GroupHierarchyType;
 import org.jabref.model.groups.GroupTreeNode;

diff --git a/src/main/resources/l10n/JabRef_da.properties b/src/main/resources/l10n/JabRef_da.properties
@@ -2356,3 +2356,4 @@ Size_of_large_icons=
 Size_of_small_icons=
 Default_table_font_size=
 Escape_underscores=
+Color=
diff --git a/src/main/resources/l10n/JabRef_de.properties b/src/main/resources/l10n/JabRef_de.properties
@@ -2356,3 +2356,4 @@ Size_of_large_icons=Größe_für_große_Icons
 Size_of_small_icons=Größe_für_kleine_Icon
 Default_table_font_size=Standard_Tabellenschriftgröße
 Escape_underscores=Unterstriche_maskieren
+Color=
diff --git a/src/main/resources/l10n/JabRef_en.properties b/src/main/resources/l10n/JabRef_en.properties
@@ -2356,3 +2356,4 @@ Size_of_large_icons=Size_of_large_icons
 Size_of_small_icons=Size_of_small_icons
 Default_table_font_size=Default_table_font_size
 Escape_underscores=Escape_underscores
+Color=Color
diff --git a/src/main/resources/l10n/JabRef_es.properties b/src/main/resources/l10n/JabRef_es.properties
@@ -2356,3 +2356,4 @@ Size_of_large_icons=
 Size_of_small_icons=
 Default_table_font_size=
 Escape_underscores=
+Color=
diff --git a/src/main/resources/l10n/JabRef_fa.properties b/src/main/resources/l10n/JabRef_fa.properties
@@ -2356,3 +2356,4 @@ Size_of_large_icons=
 Size_of_small_icons=
 Default_table_font_size=
 Escape_underscores=
+Color=
diff --git a/src/main/resources/l10n/JabRef_fr.properties b/src/main/resources/l10n/JabRef_fr.properties
@@ -2356,3 +2356,4 @@ Size_of_large_icons=Taille_des_grands_icones
 Size_of_small_icons=Taille_des_petits_icones
 Default_table_font_size=Taille_par_défaut_des_police_du_tableau
 Escape_underscores=Echapper_les_soulignements
+Color=
diff --git a/src/main/resources/l10n/JabRef_in.properties b/src/main/resources/l10n/JabRef_in.properties
@@ -2356,3 +2356,4 @@ Size_of_large_icons=
 Size_of_small_icons=
 Default_table_font_size=
 Escape_underscores=
+Color=
diff --git a/src/main/resources/l10n/JabRef_it.properties b/src/main/resources/l10n/JabRef_it.properties
@@ -2356,3 +2356,4 @@ Size_of_large_icons=
 Size_of_small_icons=
 Default_table_font_size=
 Escape_underscores=
+Color=
diff --git a/src/main/resources/l10n/JabRef_ja.properties b/src/main/resources/l10n/JabRef_ja.properties
@@ -2356,3 +2356,4 @@ Size_of_large_icons=
 Size_of_small_icons=
 Default_table_font_size=
 Escape_underscores=
+Color=
diff --git a/src/main/resources/l10n/JabRef_nl.properties b/src/main/resources/l10n/JabRef_nl.properties
@@ -2356,3 +2356,4 @@ Size_of_large_icons=
 Size_of_small_icons=
 Default_table_font_size=
 Escape_underscores=
+Color=
diff --git a/src/main/resources/l10n/JabRef_no.properties b/src/main/resources/l10n/JabRef_no.properties
@@ -2356,3 +2356,4 @@ Size_of_large_icons=
 Size_of_small_icons=
 Default_table_font_size=
 Escape_underscores=
+Color=
diff --git a/src/main/resources/l10n/JabRef_pt_BR.properties b/src/main/resources/l10n/JabRef_pt_BR.properties
@@ -2356,3 +2356,4 @@ Size_of_large_icons=
 Size_of_small_icons=
 Default_table_font_size=
 Escape_underscores=
+Color=
diff --git a/src/main/resources/l10n/JabRef_ru.properties b/src/main/resources/l10n/JabRef_ru.properties
@@ -2356,3 +2356,4 @@ Size_of_large_icons=
 Size_of_small_icons=
 Default_table_font_size=
 Escape_underscores=
+Color=
diff --git a/src/main/resources/l10n/JabRef_sv.properties b/src/main/resources/l10n/JabRef_sv.properties
@@ -2356,3 +2356,4 @@ Size_of_large_icons=
 Size_of_small_icons=
 Default_table_font_size=
 Escape_underscores=Maskera_understreck
+Color=
diff --git a/src/main/resources/l10n/JabRef_tr.properties b/src/main/resources/l10n/JabRef_tr.properties
@@ -2356,3 +2356,4 @@ Size_of_large_icons=
 Size_of_small_icons=
 Default_table_font_size=
 Escape_underscores=
+Color=
diff --git a/src/main/resources/l10n/JabRef_vi.properties b/src/main/resources/l10n/JabRef_vi.properties
@@ -2356,3 +2356,4 @@ Size_of_large_icons=
 Size_of_small_icons=
 Default_table_font_size=
 Escape_underscores=
+Color=
diff --git a/src/main/resources/l10n/JabRef_zh.properties b/src/main/resources/l10n/JabRef_zh.properties
@@ -2356,3 +2356,4 @@ Size_of_large_icons=
 Size_of_small_icons=
 Default_table_font_size=
 Escape_underscores=
+Color=