Merge pull request #831 from JabRef/fix-coverity-warnings

Fix coverity warnings
JabRef · Feb 22, 2016 · d6e1e16 · d6e1e16
2 parents c57e8ac + 6b1c815
commit d6e1e16
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 8 deletions.
diff --git a/src/main/java/net/sf/jabref/gui/help/AboutDialog.java b/src/main/java/net/sf/jabref/gui/help/AboutDialog.java
@@ -24,11 +24,12 @@
 import javax.swing.text.StyleConstants;
 import javax.swing.text.StyledDocument;
 import java.awt.*;
+import java.util.Objects;
 
 public class AboutDialog extends JDialog {
 
     public AboutDialog(JabRefFrame bf) {
-        super(bf, Localization.lang("About JabRef"), true);
+        super(Objects.requireNonNull(bf), Localization.lang("About JabRef"), true);
         setSize(new Dimension(750, 600));
         setLocationRelativeTo(null);
 

diff --git a/src/main/java/net/sf/jabref/sql/DBConnectDialog.java b/src/main/java/net/sf/jabref/sql/DBConnectDialog.java
@@ -18,10 +18,7 @@
 import java.awt.BorderLayout;
 import java.awt.event.ActionEvent;
 import java.awt.event.ActionListener;
-import java.util.ArrayList;
-import java.util.Arrays;
-import java.util.List;
-import java.util.Optional;
+import java.util.*;
 
 import javax.swing.*;
 
@@ -54,13 +51,12 @@ public class DBConnectDialog extends JDialog {
 
     /** Creates a new instance of DBConnectDialog */
     public DBConnectDialog(JFrame parent, DBStrings dbs) {
-
-        super(parent, Localization.lang("Connect to SQL database"), true);
+        super(Objects.requireNonNull(parent), Localization.lang("Connect to SQL database"), true);
 
         this.setResizable(false);
         this.setLocationRelativeTo(parent);
 
-        dbStrings = dbs;
+        dbStrings = Objects.requireNonNull(dbs);
 
         // build collections of components
         ArrayList<JLabel> lhs = new ArrayList<>();