Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix spacing in Cleanup dialog #10081

Closed
Siedlerchr opened this issue Jul 13, 2023 · 2 comments · Fixed by #10085
Closed

Fix spacing in Cleanup dialog #10081

Siedlerchr opened this issue Jul 13, 2023 · 2 comments · Fixed by #10085
Assignees
@pcabaniss
Labels
FirstTimeCodeContribution Triggers GitHub Greeter Workflow good first issue An issue intended for project-newcomers. Varies in difficulty. type: enhancement ui
Milestone
v5.10

Comments

@Siedlerchr
Copy link
Member

Siedlerchr commented Jul 13, 2023 •
edited
Loading

Is your suggestion for improvement related to a problem? Please describe.
The cleanup dialog looks ugly!

Describe the solution you'd like
Add some spacing around (top, bottom, left, right). See other dialogs like manage study definition for an example.

Additional context

Add any other context or screenshots about the feature request here.
grafik

CleanupDialog is the code related starting point

Refs #https://github.com/JabRef/jabref-issue-melting-pot/issues/237
@Siedlerchr Siedlerchr added type: enhancement ui good first issue An issue intended for project-newcomers. Varies in difficulty. labels Jul 13, 2023
@Siedlerchr Siedlerchr added this to the v5.10 milestone Jul 13, 2023
@github-project-automation github-project-automation bot moved this to Normal priority in Features & Enhancements Jul 13, 2023
@github-project-automation github-project-automation bot moved this to Free to take in Good First Issues Jul 13, 2023
@pcabaniss
Copy link
Contributor

Hi there, im a first-time contributor and would like to try my hand at this. Could you assign it to me please?

@Siedlerchr Siedlerchr added the FirstTimeCodeContribution Triggers GitHub Greeter Workflow label Jul 14, 2023
@github-actions
Copy link
Contributor

As a general advice for newcomers: check out Contributing for a start. Also, guidelines for setting up a local workspace is worth having a look at.

Feel free to ask here at GitHub, if you have any issue related questions. If you have questions about how to setup your workspace use JabRef's Gitter chat. Try to open a (draft) pull-request early on, so that people can see you are working on the issue and so that they can see the direction the pull request is heading towards. This way, you will likely receive valuable feedback.

@ThiloteE ThiloteE moved this from Free to take to Reserved in Good First Issues Jul 14, 2023
pcabaniss added a commit to pcabaniss/jabref that referenced this issue Jul 14, 2023
@pcabaniss
Fix spacing in Cleanup dialog JabRef#10081
9e411b7
@Siedlerchr Siedlerchr mentioned this issue Jul 15, 2023
Merged
6 tasks
@github-project-automation github-project-automation bot moved this from Reserved to Done in Good First Issues Jul 15, 2023
@github-project-automation github-project-automation bot moved this from Normal priority to Done in Features & Enhancements Jul 15, 2023
Siedlerchr added a commit that referenced this issue Jul 15, 2023
@pcabaniss @calixtus @Siedlerchr
Fix spacing in Cleanup dialog #10081 (#10085)
76be2a7 
* Fix spacing in Cleanup dialog #10081

* Updated UI

* Update CleanupDialog.java

Removed whitespaces

* Fixed indentation

* Removed launch.json

* Updated CHANGELOG

* Delete launch.json

---------

Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>
Co-authored-by: Christoph <siedlerkiller@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pcabaniss pcabaniss

Labels
FirstTimeCodeContribution Triggers GitHub Greeter Workflow good first issue An issue intended for project-newcomers. Varies in difficulty. type: enhancement ui
Projects
Features & Enhancements
Archived in project
Good First Issues
Archived in project
Milestone
v5.10
Development

Successfully merging a pull request may close this issue.

Fix spacing in Cleanup dialog #10081 pcabaniss/jabref
2 participants
@Siedlerchr @pcabaniss