Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search with GVK / ISBN does not work properly #10160

Closed
2 tasks done
ds-sic opened this issue Aug 13, 2023 · 4 comments
Closed
2 tasks done

Search with GVK / ISBN does not work properly #10160

ds-sic opened this issue Aug 13, 2023 · 4 comments
Labels
bug Confirmed bugs or reports that are very likely to be bugs fetcher

Comments

@ds-sic
Copy link

ds-sic commented Aug 13, 2023

JabRef version

5.9 (latest release)

Operating system

Windows

Details on version and operating system

No response

Checked with the latest development build

  • I made a backup of my libraries before testing the latest development version.
  • I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

  1. the search via GVK and also via ISBN for a new book entry works only partially. -> In GVK only items are found that have been published until 2019.
  2. Searched for example "Schadt digitalisierung" (2022/2023) or "Technologische Souveränität" (2023). Both are available at https://gso.gbv.de/
    Searching for "Digitalisierung" alone yields only 50 results. According to this, there is a limit of 50 somewhere. Searching for "Digitalisierung 2023" only brings up 6 results for me. Could the internally set limit be the reason?
  3. I have installed the current version 5.9 on Windows. However, I get the same result under Debian. Since the installation is fresh on Debian and no configurations have been made there, this seems to be a bug. The problem is with the latest development version 5.10. just checked and there the same result as described above.

Appendix

...

Log File
Paste an excerpt of your log file here
@teertinker
Copy link
Contributor

teertinker commented Aug 16, 2023

Searching with GVK raises an Exception on my 5.9
grafik

According to the Homepage from gbv there was an URL update.
https://kxpwww.k10plus.de/info/

Therefore a simple update in the fetcher file may be sufficient:

private static final String URL_PATTERN = "http://sru.gbv.de/gvk?";

URL_PATTERN = "http://sru.gbv.de/gvk?" --> URL_PATTERN = "http://sru.k10plus.de"

Sorry, but I have no JDK to test whether that works. But if I use the URL Pattern within the Exception and update it with the new URL Pattern in the browser, I get a proper XML file. So I suppose it will work.

@Siedlerchr
Copy link
Member

Thanks a lot! We will check this!

@Siedlerchr Siedlerchr added the bug Confirmed bugs or reports that are very likely to be bugs label Aug 16, 2023
Siedlerchr added a commit that referenced this issue Aug 18, 2023
Fixes Part of #10160

compare code attributes in xml with ignore case
@Siedlerchr Siedlerchr mentioned this issue Aug 18, 2023
6 tasks
@Siedlerchr
Copy link
Member

@ds-sic Hi, yes the limit of 50 is set hard in JabRef. As we rely on the goodwill of the publisher/catalogs, we have limited the results. However, the GVK Fetcher also allows searching for year https://docs.jabref.org/collect/import-using-online-bibliographic-database#search-syntax

It might be possible to implement pagination, so we don't have to fetch all the results in advance. But I am not that deep into the search options of the SRU interface.

@ds-sic
Copy link
Author

ds-sic commented Sep 10, 2023

@Siedlerchr Hej, thanks for the information, the limit is fine. And thanks for the fix. With Version 5.10 the GVP search is running again :-)

@ds-sic ds-sic closed this as completed Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs fetcher
Projects
Archived in project
Archived in project
Development

No branches or pull requests

3 participants