Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with adding elements to a group (subgroup). #10317

Closed
2 tasks done
NeymanDmitry opened this issue Sep 4, 2023 · 6 comments · Fixed by #10408
Closed
2 tasks done

Problem with adding elements to a group (subgroup). #10317

NeymanDmitry opened this issue Sep 4, 2023 · 6 comments · Fixed by #10408
Labels

Comments

@NeymanDmitry
Copy link

NeymanDmitry commented Sep 4, 2023

JabRef version

5.10 (latest release)

Operating system

GNU / Linux

Details on version and operating system

Ubuntu 22.04 (64-bit)

Checked with the latest development build (copy version output from About dialog)

  • I made a backup of my libraries before testing the latest development version.
  • I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

If you select several entries from the library and then right-click on a group (subgroup) to add these elements to the group, then the selection from the elements disappears and this group opens instead.

Appendix

...

Log File
Paste an excerpt of your log file here
@ghost
Copy link

ghost commented Sep 4, 2023

Yes I can confirm it's impossible to use the right click menu to do this. You can drag-and-drop entries from "all entries" to a subgroup.

If you right click a group (or subgroup) you get this menu:

afbeelding

The "remove selected entries from this group" works but the "add selected entries to this group" should better be placed in the right click menu of the entry table when you have any group selected.
Then you can select entries from the entry table and right click "add selected entries to group" which should show a submenu of all groups you currently have. You can then choose the group you want to add the selected entries too by using the submenu.

Also the "remove selected entries from this group" and "add selected entries to this group" are enabled if there are NO entries selected at all too. So it's very confusing.

So I think both improvements should be made to make this feature user friendly.

@Siedlerchr
Copy link
Member

Then you can select entries from the entry table and right click "add selected entries to group" which should show a submenu of all groups you currently have. You can then choose the group you want to add the selected entries too by using the submenu.

Actually, this was once implemented in JabRef in older versions. After the migration to the new UI framework, we decided to use Drag and Drop instead as the old variant is just duplicating the whole group tree

@ghost
Copy link

ghost commented Sep 4, 2023

Then you can select entries from the entry table and right click "add selected entries to group" which should show a submenu of all groups you currently have. You can then choose the group you want to add the selected entries too by using the submenu.

Actually, this was once implemented in JabRef in older versions. After the migration to the new UI framework, we decided to use Drag and Drop instead as the old variant is just duplicating the whole group tree

Maybe then both menu items should be removed completely?
And drag and drop should be used to add entries to a group? Manually selecting and deleting to remove entries from a group?

@NeymanDmitry
Copy link
Author

There is one more problem. If the list of groups and subgroups is too large, which does not fit in the window and you need to use scrolling, then when adding using the drag-and-drop method, the list scrolls spontaneously to the very bottom (after adding). To cancel scrolling, you need to rotate the mouse roller, otherwise everything repeats.

@ghost
Copy link

ghost commented Sep 6, 2023

There is one more problem. If the list of groups and subgroups is too large, which does not fit in the window and you need to use scrolling, then when adding using the drag-and-drop method, the list scrolls spontaneously to the very bottom (after adding). To cancel scrolling, you need to rotate the mouse roller, otherwise everything repeats.

I can confirm this but know no solution (I'm no developer). 😊

@Siedlerchr
Copy link
Member

Siedlerchr commented Sep 24, 2023

Might be related to #2869

github-merge-queue bot pushed a commit that referenced this issue Sep 25, 2023
* Fix adding and removing selected entries to group context menu

Fixes #10403
Fixes #10317
Fixes #10374

* remove globals
fix checkstyle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants