-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add library selection to "Aux file import" #10472
Comments
Hi, I would like to work on this issue as a part of my university assignment. Could I please be assigned to it? |
As a general advice for newcomers: check out Contributing for a start. Also, guidelines for setting up a local workspace is worth having a look at. Feel free to ask here at GitHub, if you have any issue related questions. If you have questions about how to setup your workspace use JabRef's Gitter chat. Try to open a (draft) pull-request early on, so that people can see you are working on the issue and so that they can see the direction the pull request is heading towards. This way, you will likely receive valuable feedback. |
Hi, may i give it a try as well ? although it has been assigned to someone, I also would like to solve this issue as a part of my uni assignment. |
Hi, I am still working on this. |
@OMEN-Watson Students are special. We usually only assign one group or one student to an issue. This is, because we at JabRef don't know the grading scheme and the course requirements of students involved. In particular, we don't know if group work is permitted. We also try to minimize conflict and aim to have good organisational workflows for all parties involved. We have had conflicts because of this in the past. Both publishing similar or different fixes at the same time or at different times for the same issue creates all sorts of trouble for the person that has to give you your grade. It is hard to differentiate between "cheating" and "fixing an issue in a mostly similar way by copying and pasting large parts of the solution from other students working on the same issue". Also, keep in mind that if there are two pull-requests, only one of them will be merged. For all these reasons, I would kindly ask you to choose another issue. If no students were involved, we would be happy to have cooperation and groupwork, but students are special! |
You can find other good first issues at our projects page: https://github.com/orgs/JabRef/projects/5 |
ok,easy~ i will not submit any PR,just try to fix it locally |
Hi, I have added the visuals for the library selector but I am stuck on how to implement the logic to actually select and use a particular library. Could I please have some guidance? |
@caitlinlilley check out the implementation in the ImportEntriesDialog: jabref/src/main/java/org/jabref/gui/importer/ImportEntriesDialog.java Lines 108 to 129 in 8ede31a
|
At "Tools" > "New sub library based on AUX file", JabRef generates a new .bib file based on the cited entries
The dialog shows then following
Currently, JabRef uses the currently opened library. This may lead to confusion.
We need a library selector (similar to the import dialog)
Hints:
For the import dialog, the implementation was done at #9402
The text was updated successfully, but these errors were encountered: