-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include PMID in PubMed imports #11488
Labels
bug
Confirmed bugs or reports that are very likely to be bugs
good first issue
An issue intended for project-newcomers. Varies in difficulty.
Comments
jabref/src/main/java/org/jabref/logic/importer/fileformat/MedlinePlainImporter.java Lines 145 to 168 in 7e4e7d3
|
Siedlerchr
added
bug
Confirmed bugs or reports that are very likely to be bugs
good first issue
An issue intended for project-newcomers. Varies in difficulty.
labels
Jul 12, 2024
Is this all it would take to resolve the issue? hashMap.put("PMID", new UnknownField("pmid")); |
Yes, that should be enough. You can do it through the github UI (just click on Edit File). You might need to adjust the MedlinePlainImporterTest as well if it fails but CI will tell you that :) |
Siedlerchr
added a commit
that referenced
this issue
Jul 17, 2024
github-merge-queue bot
pushed a commit
that referenced
this issue
Jul 18, 2024
* import PMID field in Pubmed Fixes #11488 * fix tests --------- Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>
github-project-automation
bot
moved this from Normal priority
to Done
in Prioritization
Jul 18, 2024
github-project-automation
bot
moved this from Free to take
to Done
in Good First Issues
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Confirmed bugs or reports that are very likely to be bugs
good first issue
An issue intended for project-newcomers. Varies in difficulty.
The MEDLINE importer does not include PubMed IDs (PMID) when importing from PubMed text files.
This is problematic for two reasons:
PubMed records also have an NLM unique identifier that JabRef imports, but this is not the same as the PMID and does not substitute for it. MEDLINE records produced by sources other than PubMed tend to include the PMID and not the NLM identifier, so the PMID is more useful for merging and deduplicating entries in JabRef. The PMID can also be used to visit the record on PubMed, fetch additional data, and so on.
The MEDLINE importer should include the
PMID
element from pubmed/medline files.See MEDLINE/PubMed Data Element (Field) Descriptions for information about the elements included in PubMed text files.
The text was updated successfully, but these errors were encountered: