Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Month" field ascending/descending sorting swapped #1687

Closed
giacomociani opened this issue Aug 6, 2016 · 4 comments
Closed

"Month" field ascending/descending sorting swapped #1687

giacomociani opened this issue Aug 6, 2016 · 4 comments

Comments

@giacomociani
Copy link

JabRef version 3.5 on Windows 10 64-bit

When sorting according to "month", "ascending"/"descending" are switched.

For "year", for example, descending order results in later years at the top, as expected.
For "month", however, descending order results in January at the top, and December at the bottom, which is inconsistent.

This affects both the main view and the order in which the entries are saved (if a custom save order based on the "month" filed is specified in the database properties).

@oscargus
Copy link
Contributor

oscargus commented Aug 7, 2016

Looking at the code it reads:

        if(fieldType == FieldType.MONTH) {
            /*
             * [ 1598777 ] Month sorting
             *
             * http://sourceforge.net/tracker/index.php?func=detail&aid=1598777&group_id=92314&atid=600306
             */
            multiplier = reversed ? 1 : -1;
        } else {
            multiplier = reversed ? -1 : 1;
        }

so something special is happening for month. However, that link is not leading anywhere as the sourceforge bug tracker is disabled for JabRef.

Should be quite easy to fix though.

@stefan-kolb stefan-kolb added this to the v3.6 milestone Aug 23, 2016
@stefan-kolb
Copy link
Member

Link just says that month sorting was not working. I also tested it and my month sorting doesn't work at all...

@stefan-kolb
Copy link
Member

Thank you for your report 👍
This should be fixed in current month-sorting. Please try the latest build from http://builds.jabref.org/month-sorting.

@giacomociani
Copy link
Author

Works fine now! Thanks.

Siedlerchr added a commit to Siedlerchr/jabref that referenced this issue Aug 25, 2016
* master:
  fix SplitPaneChangeListener (JabRef#1840)
  French localization: Jabref_fr: empty strings translated (JabRef#1847)
  Fixes JabRef#1687 "month" field ascending/descending sorting swapped (JabRef#1837)
  Fix localization entry.
  Update German translation (JabRef#1829)
Siedlerchr added a commit that referenced this issue Aug 25, 2016
* master:
  Disable incompatible properties for shared database. (#1826)
  Allow setting the etal-string empty. Implements #1841 (#1848)
  fix SplitPaneChangeListener (#1840)
  French localization: Jabref_fr: empty strings translated (#1847)
  Fixes #1687 "month" field ascending/descending sorting swapped (#1837)
  Fix localization entry.
  Update German translation (#1829)
  entry scrolling  didn't work if the entry in question was just 1 row outside the table (bottom) (<; <= mistake)
  fix indent
  when pasting an entry search the entry from the back, b/c we want to select the duplicate, not the original
  fix issues and delete a duplicate method
  when inserting a duplicate the right entry will be selected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants