Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Globals.pref dependency in BibEntryAssert #1820

Closed
Siedlerchr opened this issue Aug 22, 2016 · 3 comments
Closed

Globals.pref dependency in BibEntryAssert #1820

Siedlerchr opened this issue Aug 22, 2016 · 3 comments

Comments

@Siedlerchr
Copy link
Member

I just add another case here, I found out in #1765 which needs some special care:

In MsBibImporterTestfiles it is theoretically not needed, but if I remove it fails with an NPE, reason is
getListFromInputStream(InputStream is) in BibEntryAssert loads prefs from Globals.prefs

@oscargus As you are currently reworking that globals stuff, just one thing I noticed. Maybe you can add fix, this one, too.
@oscargus
Copy link
Contributor

Included in #1819. :-)

@oscargus
Copy link
Contributor

But I haven't touched the tests for specific importers (yes).

@oscargus
Copy link
Contributor

Now I touched the importers...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Siedlerchr @oscargus