Export to Office 2007 #1765
Merged
Export to Office 2007 #1765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 17, 2016
| @@ -0,0 +1,15 @@ | |||
| % Encoding: UTF-8 | |||
|
|
|||
| @InBook{Orlowski;2011, | |||
There was a problem hiding this comment.
Please name the test files after what they do and minimize them, not like the Stupro did just enumerating them 😄
Siedlerchr
added
the
status: ready-for-review
|
I would like to merge this in for 3,6 (No Localization changes), after I rebase |
Remove empty line in changelog Fix failing test and add new test file Issue gets exported as issue Journaltitle and journal both get exoprted as JournalName patennumber gets exported correctly Fix checkstyle Create better structure for import test TODO: Fix import of journal! Importer maps to biblatex fields for most fields JournalName maps to journaltitle Month can be imported and exported Patentnumber gets importerd as number when the entryType is a patent Remove msbib-patentnumber Correct tests, use utf8 encoding Create new file for empty test to avoid conflict with other imports Use Latex2Unicode formatter for Author names, too Search/split "and" in authors field case insenstive Some code cleanups Use more optionals Export number as issue, when issue field not present Rework some test files Removed some Globals, reworked Tests Day is MSBib only Make Language methods deprecated
|
|
||
| - Fixed [#1750](https://github.com/JabRef/jabref/issues/1750): BibLaTeX `date` field is now correctly exported as `year` in MS-Office 2007 xml format | ||
| - Fixed: LaTeX characters in author names are now converted to Unicode before export in MS-Office 2007 xml format | ||
| - Fixed: `Volume`, `Journaltitle`, `Issue` and `number`(for Patents) fields are now exported correctly in MS-Office 2007 xml format |
There was a problem hiding this comment.
all field names in lower case. Space after number. Patents with lower case "p"
|
Looks good! Just some minor comments. |
|
I will fix it this afternoon/evening. Regarding the language mapping, there is not yet a simple solution, as we would have to integrate the whole table of LCID: https://msdn.microsoft.com/de-de/goglobal/bb964664.aspx |
| @@ -77,12 +81,26 @@ public static BibEntry convert(MSBibEntry entry) { | |||
| fieldValues.put(MSBIB_PREFIX + "accessed", entry.dateAccessed); | |||
| } | |||
|
|
|||
| if(entry.journalName != null) | |||
| { | |||
Remove some empty lines
|
Address comments as far as possible |
* master: Disable incompatible properties for shared database. (#1826) Allow setting the etal-string empty. Implements #1841 (#1848) fix SplitPaneChangeListener (#1840) French localization: Jabref_fr: empty strings translated (#1847) Fixes #1687 "month" field ascending/descending sorting swapped (#1837) Fix localization entry. Update German translation (#1829) entry scrolling didn't work if the entry in question was just 1 row outside the table (bottom) (<; <= mistake) fix indent when pasting an entry search the entry from the back, b/c we want to select the duplicate, not the original fix issues and delete a duplicate method when inserting a duplicate the right entry will be selected
3 tasks
ayanai1
pushed a commit
to ayanai1/jabref
that referenced
this pull request
Sep 5, 2016
* Export year to office 2007 correclty when only date is set in biblatex Remove empty line in changelog Fix failing test and add new test file Issue gets exported as issue Journaltitle and journal both get exoprted as JournalName patennumber gets exported correctly Create better structure for import test Importer maps to biblatex fields for most fields JournalName maps to journaltitle Month can be imported and exported Patentnumber gets importerd as number when the entryType is a patent Remove msbib-patentnumber Correct tests, use utf8 encoding Create new file for empty test to avoid conflict with other imports Use Latex2Unicode formatter for Author names, too Search/split "and" in authors field case insenstive Export number as issue, when issue field not present Rework some test files Day is MSBib only * Rebased and addded new changelog entries * Address comments, fix javadoc, changelog and add some StringBuilder Remove some empty lines * Merge changes and remove some empty lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First fix for #1750.
I will continue reworking some other fields, too and will add some more tests.