Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Articles can no longer be assigned to groups via drag'n'drop #2098

Closed
AEgit opened this issue Sep 29, 2016 · 15 comments
Closed

Articles can no longer be assigned to groups via drag'n'drop #2098

AEgit opened this issue Sep 29, 2016 · 15 comments
Labels
bug Confirmed bugs or reports that are very likely to be bugs groups ui

Comments

@AEgit
Copy link

AEgit commented Sep 29, 2016

JabRef 3.7dev--snapshot--2016-09-29--latex-free-fields--93e665e
windows 10 10.0 amd64
Java 1.8.0_101

  1. Select an item and try to drag'n'drop it onto an existing group
  2. Nothing happens
  3. Adding the groups name manually to the "Groups" field of the item does work, however, and assigns the item to the group

(see also: #1993)

@AEgit
Copy link
Author

AEgit commented Sep 30, 2016

This bug is still present in:

JabRef 3.7dev--snapshot--2016-09-30--latex-free-fields--0ee1d17

@AEgit
Copy link
Author

AEgit commented Oct 3, 2016

The bug is also present in the current master build:
JabRef 3.7dev--snapshot--2016-10-03--master--565676c

@koppor
Copy link
Member

koppor commented Oct 3, 2016

Thank you for constantly checking. You see pull requests listed here as soon as someone starts working in it. We currently have no money to pay someone for that. Thus, it depends on our free time. - If you can spend some more time, we would like to encourage you to check https://help.jabref.org/en/FAQcontributing - especially the part asking for improvement of our help pages https://help.jabref.org/en/. We have plenty of open issues there: https://github.com/JabRef/help.jabref.org/issues/

@AEgit
Copy link
Author

AEgit commented Oct 3, 2016

@koppor: When rereading my comments I realize that it may sound as I was blaming the development team for not having fixed the issue already. I'm sorry if I came across like this, that was never my intention! I've just reported the presence of this bug in the master build, because previously it was just present in one of the other branches and I wanted to make sure, that everyone knew it was now also present in the master branch.
Thanks again for this great piece of software! I shall see, whether I can devote some time to improve the help pages!

@lenhard
Copy link
Member

lenhard commented Oct 3, 2016

@AEgit Nevermind :-) We need good and reproducible issue reporting. Our main problem is that we currently do not have the man power to keep up with issue fixing. As long as you do not get angry when the issue lies around unfixed, we won't be angry as well.

Having said that, you do appear as someone who would like to contribute. If so, this will be very welcome! Even if you cannot produce code, there are many ways in which you could help. Many things should be updated or documented and we will be very grateful if you help for instance with the web pages. @mlep is sort of our managing director for localization and documentation, I am sure he can provide a few more pointers.

@lenhard lenhard changed the title Bug: Articles can no longer be assigned to groups via drag'n'drop Articles can no longer be assigned to groups via drag'n'drop Oct 3, 2016
@AEgit
Copy link
Author

AEgit commented Oct 3, 2016

@lenhard : No worries, I will definitely not get angry. Most bugs I report, are just small things - it would be nice, if they were fixed, but they are no show-stoppers. I just tend to report a bug, when I come across it.
If there ever was a show-stopper that couldn't be fixed in time I would either have to a) learn Java and try to fix it on my own or b) look for an alternative to Jabref. But there should never be any hard feelings, as Jabref is a free and open source project - no reason for the users to "demand" something.

Thanks also for pointing out, how I could further contribute to the project! I'll see what I can do about it!

@mlep
Copy link
Contributor

mlep commented Oct 3, 2016

@AEgit: Since you seem a heavy user of JabRef, you may know in details some of its features.
Currenly, part of JabRef help is outdated (e.g. https://help.jabref.org/en/FileLinks) or in the state of a stub (e.g. https://help.jabref.org/en/CleanupEntries). So your knowledge of JabRef could be quite helpful!

I suggest you to browse through the help (https://help.jabref.org/en/), to pick up an item to work on, and to create an Issue (https://github.com/JabRef/help.jabref.org/issues) to signal what is being done (so that somebody else does not start improving the same item...).

Additionally:

@AEgit
Copy link
Author

AEgit commented Oct 4, 2016

@mlep: Thank you very much for the information! I shall have a look at it. I might be able to help with the translation to German and Italian.

@lenhard: I've seen you've added the labels "enhancement", "groups" and "ui". Shouldn't there also be "bug"? Because this functionality was present in previous versions - indeed, this is actually a regression.
Furthermore, this issue seems to also affect the group assignment: It is not possible anymore to drag'n'drop one group to another to create a group-subgroup relationship.

@lenhard lenhard added bug Confirmed bugs or reports that are very likely to be bugs and removed type: enhancement labels Oct 4, 2016
@lenhard
Copy link
Member

lenhard commented Oct 4, 2016

@AEgit You are correct, thanks for pointing out!

matthiasgeiger added a commit that referenced this issue Oct 14, 2016
Fixes #2119 and #2098 
* fix group drag and drop

* log exception
@matthiasgeiger
Copy link
Member

Just merged a fix to master, i.e., the new dev builds should work again.

@AEgit
Copy link
Author

AEgit commented Oct 14, 2016

Thanks a lot!

I can confirm that this bug has been fixed in:
JabRef 3.7dev--snapshot--2016-10-14--master--fb0990d

I've just noticed one new behaviour with this fix compared to older versions, which did not exhibit this bug. Previously, when you reassigned an item/article to a new group, the format of the added lines in the "Groups" field would be as follows:

OldGroup_1, OldGroup_2, NewGroup_1, NewGroup_2

With the new fixed version, the new groups NewGroup_1 and NewGroup_2 are added as follows:

OldGroup_1, OldGroup_2,NewGroup_1,NewGroup2

i.e., in the new fixed version, there's no space between the commas separating the new entries. I just wanted to report this, as I'm not sure whether this is an intended change and/or whether this new behaviour causes any issues.

@matthiasgeiger
Copy link
Member

Thanks for the feedback.

@tobiasdiez Is this intended? Or can this cause some trouble?

@AEgit
Copy link
Author

AEgit commented Oct 20, 2016

Can we reopen this? Or should I create a new ticket? The problem itself is fixed, but I just wanted to make sure, that the different/new behaviour does not cause any other issues - see posts above.

@tobiasdiez
Copy link
Member

This behavior is not intended. @AEgit can you open a new issue please.

@AEgit
Copy link
Author

AEgit commented Oct 21, 2016

Done. See here:
#2184

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs groups ui
Projects
None yet
Development

No branches or pull requests

6 participants