Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The autocompletion does not work perfectly #2998

Closed
iTao8 opened this issue Jul 11, 2017 · 5 comments
Closed

The autocompletion does not work perfectly #2998

iTao8 opened this issue Jul 11, 2017 · 5 comments
Assignees
@tobiasdiez
Labels
autocompletion bug Confirmed bugs or reports that are very likely to be bugs search
Milestone
v4.0

Comments

@iTao8
Copy link

iTao8 commented Jul 11, 2017 •
edited
Loading

JabRef 4.0.0-dev--snapshot--2017-07-11--master--e35b6ac2c
Mac OS X 10.11.6 x86_64
Java 1.8.0_131

The bugs:

  1. The autocompletion does not work in the author and journal fields.

  2. The autocompletion dropdown box gives many same items. When you search something once more, there are two dropdown boxes overlap there.

screen shot 2017-07-12 at 6 47 45 am
screen shot 2017-07-12 at 6 48 05 am
@tobiasdiez tobiasdiez self-assigned this Jul 11, 2017
@tobiasdiez tobiasdiez added this to the v4.0 milestone Jul 11, 2017
@tobiasdiez tobiasdiez added autocompletion bug Confirmed bugs or reports that are very likely to be bugs search labels Jul 11, 2017
tobiasdiez added a commit that referenced this issue Jul 12, 2017
@tobiasdiez
Fix #2998: improve auto completion
f667b9e
@tobiasdiez
Copy link
Member

Thanks for the quick feedback!

This should be fixed in the latest development version. Could you please check the build from http://builds.jabref.org/master/. Thanks!
Sometimes you still get the same suggestion in the search bar. This happens when the same author is entered in different ways (for example, once as "Tao, I." and also as "Tao, IdontKnow" so that the suggestion is "Tao, I." in both cases). There is nothing I can do at the moment but reporting the issue at .

Moreover, I couldn't replicate the two overlapping dropdown boxes (on Windows). What are the exact steps to reproduce this problem?

Siedlerchr added a commit that referenced this issue Jul 15, 2017
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into selectFilesDlg
f4a58c3 
* upstream/master: (30 commits)
  Add preference migration for keybdingings (#3007)
  Shutdown previus AutosaveManager and BackupManager during SaveAs  (#2994)
  Run Checkstyle task after Test task (#3010)
  Mark LibraryOfCongressTest as a fetcher test (#3012)
  When browsing through the MainTable remember which EntryEditor tab was open (#3011)
  Improve performance of journal abbreviation loader (#3009)
  Update checkstyle 7.6.1 -> 8.0
  Don't abort build when there are checkstyle violations (#3006)
  Reimplement content selectors (#3003)
  Only do a back up for bigger changes or if a different field is edited (#3004)
  Listen to change events for setting dirty status of database (#3001)
  Fix #2967: MathSciNet tab works again
  Fix #2902: Tab in entry editor moves to next text area
  Fix #2946: external changes are now correctly shown in the entry editor
  Fix #2998: improve auto completion (#3002)
  Fix mac keybinding by replacing ctrl it with meta key (#3000)
  Less backups (#2995)
  [WIP] Complete rework of the auto completion (#2965)
  Eclipse J
  Add switch indentation for Eclipse and add some new missing formatting options
  ...
Siedlerchr added a commit that referenced this issue Jul 15, 2017
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into sharelatex
6512fc6 
* upstream/master:
  Add preference migration for keybdingings (#3007)
  Shutdown previus AutosaveManager and BackupManager during SaveAs  (#2994)
  Run Checkstyle task after Test task (#3010)
  Mark LibraryOfCongressTest as a fetcher test (#3012)
  When browsing through the MainTable remember which EntryEditor tab was open (#3011)
  Improve performance of journal abbreviation loader (#3009)
  Update checkstyle 7.6.1 -> 8.0
  Don't abort build when there are checkstyle violations (#3006)
  Reimplement content selectors (#3003)
  Only do a back up for bigger changes or if a different field is edited (#3004)
  Listen to change events for setting dirty status of database (#3001)
  Fix #2967: MathSciNet tab works again
  Fix #2902: Tab in entry editor moves to next text area
  Fix #2946: external changes are now correctly shown in the entry editor
  Fix #2998: improve auto completion (#3002)
  Fix mac keybinding by replacing ctrl it with meta key (#3000)
  Less backups (#2995)
  [WIP] Complete rework of the auto completion (#2965)
@iTao8
Copy link
Author

iTao8 commented Jul 21, 2017

JabRef 4.0-dev--snapshot--2017-07-19--master--894799b2f
Mac OS X 10.11.6 x86_64
Java 1.8.0_131

The autocompletion dropdown box for the journal field covers the input
screen shot 2017-07-21 at 6 27 11 pm

@iTao8
Copy link
Author

iTao8 commented Jul 21, 2017

@tobiasdiez To reproduce the overlapping dropdown box, you just need to search an author two or more times.

It seems that the autocompletion in the search bar can only work for the author, not for journal and some other thing, is it?

My current version is
JabRef 4.0-dev--snapshot--2017-07-19--master--894799b2f
Mac OS X 10.11.6 x86_64
Java 1.8.0_131

@tobiasdiez
Copy link
Member

In order to adress #2998 (comment), @lenhard do you think we can adopt your recent solution for the BackupManager so that only bigger changes lead to an update of the autocompletion suggestions?

@lenhard
Copy link
Member

lenhard commented Jul 25, 2017

@tobiasdiez Sorry, I have very little time at the moment. You should be able to do something similar as for the BackupManager, though. The DatabaseChangedEvent carries information about the delta that you can use.

@tobiasdiez tobiasdiez reopened this Jul 27, 2017
@tobiasdiez tobiasdiez mentioned this issue Aug 6, 2017
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tobiasdiez tobiasdiez

Labels
autocompletion bug Confirmed bugs or reports that are very likely to be bugs search
Projects
None yet
Milestone
v4.0
Development

No branches or pull requests
3 participants
@lenhard @tobiasdiez @iTao8