Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JR doesn't send citation commands to TeXworks #3197

Closed
Doc73 opened this issue Sep 5, 2017 · 12 comments · Fixed by #10953
Closed

JR doesn't send citation commands to TeXworks #3197

Doc73 opened this issue Sep 5, 2017 · 12 comments · Fixed by #10953
Assignees
@vladdobre
Labels
FirstTimeCodeContribution Triggers GitHub Greeter Workflow good first issue An issue intended for project-newcomers. Varies in difficulty. type: feature

Comments

@Doc73
Copy link
Contributor

Doc73 commented Sep 5, 2017

JabRef 4.0-beta3
Linux 4.11.0-0.bpo.1-amd64 amd64 on Debian 9 Stretch AMD64
Java 1.8.0_141

Steps to reproduce:

  1. Launch TeXworks and JabRef
  2. Select a bibliographic item
  3. Click on "Send to LaTeX editor"
  4. Nothing appens

In settings LaTeX editor is set to default /usr/bin/texworks.

Thank you very much in advance.
@mlep
Copy link
Contributor

mlep commented Sep 5, 2017

In fact, LatexEditor is a specific software (see http://www.latexeditor.org/).
So, it makes sense that selecting LatexEditor as external program does not work for TeXworks.
In fact, currently, TeXworks is not supported by JabRef (supported editors are Emacs, LatexEditor, Lyx/Kyle, Texmaker, TeXstudio, Vim and WinEdt.

@Doc73
Copy link
Contributor Author

Doc73 commented Sep 5, 2017

Yes, but

  1. LatexEditor is configured to point to /usr/bin/texworks
  2. I remember that in previous versions of JR it worked very well

Alternatively, can you add support for TW?

@Siedlerchr
Copy link
Member

I could not find any information regarding commandline usage from Texworks, only that issue:
You could try to see what --help offers
TeXworks/texworks#113
It would be nice if you could try to find information for inserting citation.
In TexMaker for example it's -insert

@Doc73
Copy link
Contributor Author

Doc73 commented Sep 6, 2017

@Siedlerchr
Unfortunately, --help offers only this:

Usage: texworks [opts/args]
--help, -? Display this message
--position=..., -p=... Open the following file at the given position (line or page)
--version, -v Display version information

and I'm using the latest stable version 0.6.2 (Apr 2017). :-(

@Siedlerchr
Copy link
Member

@Doc73 Sorry, then we have no chance to implement this. I would suggest creating an issue at the Texworks repository asking and referencing this.

@Siedlerchr Siedlerchr added the status: wontfix Bugs or suggestions that we are not able to fix or don't have the resource to implement. label Sep 6, 2017
@Doc73
Copy link
Contributor Author

Doc73 commented Sep 6, 2017

Yes, I understood. Many thanks! :-)

@Siedlerchr
Copy link
Member

I close this issue now. If you have more information regarding the command line usage, then feel free to reopen it.

@matteofg matteofg mentioned this issue May 10, 2023
Closed
@Siedlerchr Siedlerchr reopened this Jan 18, 2024
@Siedlerchr Siedlerchr added type: feature and removed status: wontfix Bugs or suggestions that we are not able to fix or don't have the resource to implement. labels Jan 18, 2024
@github-project-automation github-project-automation bot moved this to Normal priority in Features & Enhancements Jan 18, 2024
@Siedlerchr
Copy link
Member

Siedlerchr commented Jan 18, 2024 •
edited
Loading

Thanks to the work at Texworks, see this commit TeXworks/texworks@c868937 the issue can now be solved from the JabRef side.

Steps for implementation:

  1. Implement a new PushToApplication app like the others
  2. Add an icon (ask maintainers for licensed/free svg) to the JabRefIcon ttf font (This will be a task for JabRef maintainers) in the meantime use a simple default icon

@Siedlerchr Siedlerchr added the good first issue An issue intended for project-newcomers. Varies in difficulty. label Jan 18, 2024
@github-project-automation github-project-automation bot moved this to Free to take in Good First Issues Jan 18, 2024
@vladdobre
Copy link
Contributor

Hi, can I work on this issue (and assign it to myself?)

@koppor koppor moved this from Free to take to Reserved in Good First Issues Feb 23, 2024
@koppor koppor added the FirstTimeCodeContribution Triggers GitHub Greeter Workflow label Feb 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

As a general advice for newcomers: check out Contributing for a start. Also, guidelines for setting up a local workspace is worth having a look at.

Feel free to ask here at GitHub, if you have any issue related questions. If you have questions about how to setup your workspace use JabRef's Gitter chat. Try to open a (draft) pull-request early on, so that people can see you are working on the issue and so that they can see the direction the pull request is heading towards. This way, you will likely receive valuable feedback.

@koppor
Copy link
Member

koppor commented Feb 23, 2024

@vladdobre Welcome to the club of open source developers. I assigned you and changed the state to "reserved".

Blezie added a commit to vladdobre/jabref that referenced this issue Feb 26, 2024
@Blezie @JohannBiorck
add TeXworks (Icon needs fixing) (JabRef#3197)
87bbea2 
Co-Authored-By: JohannBiorck <85625348+johannbiorck@users.noreply.github.com>
lachiri-ilias added a commit to vladdobre/jabref that referenced this issue Feb 27, 2024
@lachiri-ilias
feat: add test for pushToTeXworks (JabRef#3197)
76388de
Blezie added a commit to vladdobre/jabref that referenced this issue Feb 28, 2024
@Blezie @JohannBiorck
refactor: change icon to default icon (JabRef#3197)
8dc5510 
Co-Authored-By: JohannBiorck <85625348+johannbiorck@users.noreply.github.com>
Blezie added a commit to vladdobre/jabref that referenced this issue Feb 28, 2024
@Blezie
fix: add TeXworks to applicationCommands (JabRef#3197)
a8eafd7
@lachiri-ilias lachiri-ilias mentioned this issue Feb 28, 2024
Closed
Blezie added a commit to vladdobre/jabref that referenced this issue Feb 29, 2024
@Blezie @JohannBiorck
doc: javadoc for PushToTeXworks (JabRef#3197)
b8d7079 
Co-Authored-By: JohannBiorck <85625348+johannbiorck@users.noreply.github.com>
lachiri-ilias added a commit to vladdobre/jabref that referenced this issue Feb 29, 2024
@lachiri-ilias
Fix: find the test error + add other test (JabRef#3197)
7fd5d07
lachiri-ilias added a commit to vladdobre/jabref that referenced this issue Feb 29, 2024
@lachiri-ilias
Merge branch 'JabRef#3197-TeXworks' of github.com:vladdobre/jabref into
5b69389 
JabRef#3197-TeXworks
Blezie added a commit to vladdobre/jabref that referenced this issue Feb 29, 2024
@Blezie @JohannBiorck @lachiri-ilias
add more tests and setCommandPath in PushToTeXworks (JabRef#3197)
bd834b9 
Co-Authored-By: JohannBiorck <85625348+johannbiorck@users.noreply.github.com>
Co-Authored-By: LACHIRI ILIAS <67273129+lachiri-ilias@users.noreply.github.com>
vladdobre added a commit to vladdobre/jabref that referenced this issue Mar 1, 2024
@vladdobre
Merge branch 'JabRef:main' into JabRef#3197-TeXworks
69876f8
vladdobre added a commit to vladdobre/jabref that referenced this issue Mar 1, 2024
@vladdobre
doc: Update CHANGELOG.md JabRef#3197
ba232f5 
Updated changelong to reflect changes.
@vladdobre vladdobre mentioned this issue Mar 1, 2024
Merged
6 tasks
Blezie added a commit to vladdobre/jabref that referenced this issue Mar 1, 2024
@Blezie @vladdobre @Kr1st1an-F
fix: Fix Checkstyle for PushToTeXworksTest JabRef#3197
37f3bc7 
Co-Authored-By: Vlad Dobre <29517124+vladdobre@users.noreply.github.com>
Co-Authored-By: Kr1st1an-F <100246316+kr1st1an-f@users.noreply.github.com>
Blezie added a commit to vladdobre/jabref that referenced this issue Mar 1, 2024
@Blezie @vladdobre @Kr1st1an-F
fix: checkstyle for PushToTeXworksTest (end with newline) and openrew…
bb912ba 
…rite JabRef#3197

Co-Authored-By: Vlad Dobre <29517124+vladdobre@users.noreply.github.com>
Co-Authored-By: Kr1st1an-F <100246316+kr1st1an-f@users.noreply.github.com>
lachiri-ilias added a commit to vladdobre/jabref that referenced this issue Mar 4, 2024
@lachiri-ilias
Fix: fix suggestion for the pull request (JabRef#3197)
b5a4f2a
koppor added a commit to vladdobre/jabref that referenced this issue Mar 4, 2024
@koppor
Merge branch 'main' into JabRef#3197-TeXworks
705a270
calixtus added a commit to vladdobre/jabref that referenced this issue Mar 4, 2024
@calixtus
Merge branch 'main' into JabRef#3197-TeXworks
b0936c3
github-merge-queue bot pushed a commit that referenced this issue Mar 4, 2024
@vladdobre @Blezie
@JohannBiorck @lachiri-ilias @Kr1st1an-F @koppor @calixtus
Add support for TeXworks (#10953)
43eb3ef 
* add TeXworks (Icon needs fixing) (#3197)

Co-Authored-By: JohannBiorck <85625348+johannbiorck@users.noreply.github.com>

* feat: add test for pushToTeXworks (#3197)

* refactor: change icon to default icon (#3197)

Co-Authored-By: JohannBiorck <85625348+johannbiorck@users.noreply.github.com>

* fix: add TeXworks to applicationCommands (#3197)

* doc: javadoc for PushToTeXworks (#3197)

Co-Authored-By: JohannBiorck <85625348+johannbiorck@users.noreply.github.com>

* Fix: find the test error + add other test (#3197)

* add more tests and setCommandPath in PushToTeXworks (#3197)

Co-Authored-By: JohannBiorck <85625348+johannbiorck@users.noreply.github.com>
Co-Authored-By: LACHIRI ILIAS <67273129+lachiri-ilias@users.noreply.github.com>

* doc: Update CHANGELOG.md #3197

Updated changelong to reflect changes.

* fix: Fix Checkstyle for PushToTeXworksTest #3197

Co-Authored-By: Vlad Dobre <29517124+vladdobre@users.noreply.github.com>
Co-Authored-By: Kr1st1an-F <100246316+kr1st1an-f@users.noreply.github.com>

* fix: checkstyle for PushToTeXworksTest (end with newline) and openrewrite #3197

Co-Authored-By: Vlad Dobre <29517124+vladdobre@users.noreply.github.com>
Co-Authored-By: Kr1st1an-F <100246316+kr1st1an-f@users.noreply.github.com>

* Fix: fix suggestion for the pull request (#3197)

* Update src/main/java/org/jabref/gui/push/PushToTeXworks.java

* Modified tests, moved comments to interface

---------

Co-authored-by: maxisr <maxism29.mi@gmail.com>
Co-authored-by: JohannBiorck <85625348+johannbiorck@users.noreply.github.com>
Co-authored-by: LACHIRI <lachiri@kth.se>
Co-authored-by: LACHIRI ILIAS <67273129+lachiri-ilias@users.noreply.github.com>
Co-authored-by: Kr1st1an-F <100246316+kr1st1an-f@users.noreply.github.com>
Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>
Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>
@github-project-automation github-project-automation bot moved this from Normal priority to Done in Features & Enhancements Mar 4, 2024
@github-project-automation github-project-automation bot moved this from Reserved to Done in Good First Issues Mar 4, 2024
@Siedlerchr
Copy link
Member

TeXWorks must be at least Version 0.6.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vladdobre vladdobre

Labels
FirstTimeCodeContribution Triggers GitHub Greeter Workflow good first issue An issue intended for project-newcomers. Varies in difficulty. type: feature
Projects
Features & Enhancements
Archived in project
Good First Issues
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for TeXworks vladdobre/jabref
5 participants
@Siedlerchr @Doc73 @koppor @mlep @vladdobre