Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Position of Special Field Columns is reset #3354

Closed
dfischer049 opened this issue Oct 26, 2017 · 11 comments
Closed

Position of Special Field Columns is reset #3354

dfischer049 opened this issue Oct 26, 2017 · 11 comments

Comments

@dfischer049
Copy link

dfischer049 commented Oct 26, 2017

JabRef version 4.1-dev on Windows

Steps to reproduce:

  1. Activate the special fields (rank/priority/...)
  2. Change the position of the columns in the table
    3a. Go to preferences and click OK, then the columns are shifted to the right of the table
    3b. Also after restarting jabref...
@lenhard
Copy link
Member

lenhard commented Oct 27, 2017

It is news to me that you should be able to configure the order of fields in the main table. @JabRef/developers Did a feature like this ever exist?

@Siedlerchr
Copy link
Member

Interesting. I never cared about this, but I could reproduce this. If I rearrange the columns, the order is not saved upon exiting. But as far as I remember, nobody touched the Maintable code for ages.
Maybe there is/was a reason to not save this?

@Siedlerchr Siedlerchr added bug Confirmed bugs or reports that are very likely to be bugs maintable ui labels Oct 27, 2017
@lenhard
Copy link
Member

lenhard commented Oct 27, 2017

@Siedlerchr So this has actually been working at some point? You could actually rearrange columns just by dragging and JabRef would store that somehow?

@Siedlerchr
Copy link
Member

@lenhard I actually have no idea if this ever worked. Mabye @koppor remembers this

@matthiasgeiger
Copy link
Member

This should work for all "Standard" columns - However the configuration of the Special field order was never possible as they are treated completely different and I had not the nerves to refactor this shitload of messy code 😜

@dfischer049
Copy link
Author

Maybe it would be helpfull to shift them to the left (should not be as hard as treating them like the other columns).

@dfischer049
Copy link
Author

@lenhard You can rearrange the "non special" columns and then update the column order in preferences to the one you set up in the table. This is working well, but as mentioned, not for the special columns.

@dfischer049
Copy link
Author

Hey there,

I managed out, that the order of columns is given by the updateTableFormat() in org\jabref\gui\maintable\MainTableFormat.java.

By moving the code for the special columns after the URL_Column part, the special columns are placed right after url column, in case, that they are activated. I was able to test it locally and seems to work.

@Siedlerchr
Copy link
Member

Thanks for your analysis of the problem. So if the cols are after URL their position will be stored?

I would say, go for a PR so we can see the changes in the code

@dfischer049
Copy link
Author

As matthiasgeiger said, storing the position is still not possible. What happens is, that at redrawing the maintable, the special field columns are always added directly after the URL column. The question is, if anyone beside me finds it more convenient to have the columns added to the left.

I will open a PR today or tomorrow so you can see what I mean.

@tobiasdiez
Copy link
Member

This should be fixed in the latest development version. Could you please check the build from http://builds.jabref.org/master/. Thanks! Please remember to make a backup of your library before trying-out this version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants