Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed fixed position of special columns. #3354 #3416

Closed
wants to merge 1 commit into from
Closed

Changed fixed position of special columns. #3354 #3416

wants to merge 1 commit into from

Conversation

dfischer049
Copy link

@dfischer049 dfischer049 commented Nov 8, 2017

When activating the special columns in the preferences, all of them are added to the right of the maintable. Each restart of Jabref or rebuild of the maintable caused the columns to be added on the right side. #3354

I changed the fixed position of the special columns from the right of the maintable to the right of the URL column. I think this position makes it easier to work with these columns, because you have interesting information like read status in the beginning of the table.

I did this by rearranging the order in which the columns are added to the maintable. Because the special columns are treated different to the basic columns, you cannot change order within preferences.

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)
  • If you changed the localization: Did you run gradle localizationUpdate?

@matthiasgeiger
Copy link
Member

Just a quick remark from the Off as I do Not have the time to check.

I think due to a proposal by @koppor we intentionally moved the columns from the left to the far right side... We should check that

@lenhard
Copy link
Member

lenhard commented Nov 18, 2017

Let us discuss the positioning of the special fields among the developers during the next devcall.

@lenhard lenhard added status: devcall status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers labels Nov 18, 2017
@koppor
Copy link
Member

koppor commented Nov 22, 2017

I think, we discussed that two years ago, but I don't remember. For me, moving it to the front is OK. But that might disturb new users of JabRef, because they first see the stars...

Do we need an additional preference? ^^

@dfischer049
Copy link
Author

I could be nice to have the choice/option to either insert them in the beginning or end of the table . Another solution would be splitting the special columns and move only the stars/rating to the end of table.

@lenhard lenhard removed status: devcall status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers labels Dec 8, 2017
@lenhard
Copy link
Member

lenhard commented Dec 8, 2017

@devBeginner We've now talked this through among the core developers.

Unfortunately, we've decided against this solution. Moving the fields to the front for all users is just too strong a thing to do and might upset users. After all, there might be people who are very happy with having them on the right side. A fixed hard-coded moving of the special fields is not the way to go.

This should be solved in an alternative way, either:

  • Fixing the bug that prevents the manual resorting of special fields to be stored and saved among different sessions of JabRef
  • Introducing a new preference option that manages the order of special fields as suggested by @koppor

We know that these things are not trivial, but ultimately they are a better way to address the underlying problem.

You're very welcome to take one of these directions and you can do so in this PR if you want.

@koppor
Copy link
Member

koppor commented Dec 22, 2017

@devBeginner Sorry not to hear any feedback from you. We will close this, but hope, you will continue working on it --> we will be happy to reopen then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants