-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC fetcher compatibility with drafts #7305
Comments
I'll take a look at this soon |
@Siedlerchr Hi, I verified the download URL of the RFC resource. There will be different URLs for different versions, the main difference is the official release version and the draft version. It has three versions
Their bibtex item download links are:
For the official release version of RFC, visit the download link of the draft version, they will be redirected to the official release version. In other words, access to https://datatracker.ietf.org/doc/draft-ietf-http-v10-spec/bibtex/ will be redirected to https://datatracker.ietf.org/doc/rfc1945/bibtex/. In JabRef, the download link format of the bibtex item is forced to https://datatracker.ietf.org/doc/rfc{number}/bibtex/.
So for some bibtex items that only have a draft version, JabRef will not be able to download correctly. E.g https://datatracker.ietf.org/doc/draft-ietf-sidrops-aspa-verification/bibtex/. |
So when the draft redirects to the "release" version, it should be sufficient to fetch the draft and follow any redirects? |
The problem now is that for some bibtex items that do not have the "release" version, JabRef will not be able to download correctly. We may need to add an option |
@Siedlerchr I think this bug can be solved by judging whether the identifier prefix contains "draft". I also added some testcases. See PR 7674. |
* upstream/main: (354 commits) Fix ScienceDirect fetcher (#7684) Refactor NoBibTexFieldCheckerTest to increase mutation coverage (#7697) Update Gradle from 6.8.3 to 7.0 (#7619) Fixes Jabref#7305: the RFC fetcher is not compatible with the draftFix for issue 7305 (#7674) Refactoring existing unit tests (#7693) cover boundary cases & add more unit tests (#7694) Bump classgraph from 4.8.104 to 4.8.105 (#7688) Bump java-diff-utils from 4.9 to 4.10 (#7692) Fix arXiv fetcher tests (#7686) Make key for ScienceDirect configurable (#7683) migration of timestamp (#7671) Fix CCSB and DOAJ (#7426) [Bot] Update CSL styles (#7680) MS Office XML: Export month name (#7677) linkfix (#7678) readd fix (#7675) Fix threading cleanup in performSearch (#7672) add missing changelog delete bug fix (#7580) Add more unit tests to three gui classes (#7636) ... # Conflicts: # build.gradle
RFC fetcher does not process drafts IDs, because
prefixedIdentifier
does not begin withrfc
prefix.Example URL for draft's raw bibtex resource https://datatracker.ietf.org/doc/draft-ietf-sidrops-aspa-verification/bibtex
URL structure is the same as in RFC resource, so no change in fetching part is required.
Ref: #3971 5d23970 @jacksonrya
Thanks in advance.
The text was updated successfully, but these errors were encountered: