-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MS Office XML: Export month name #7677
Conversation
fix checkstyle in changelog
I don't have an issue with changing the default behavior as I believe both are supported, but from my point of view the behavior pre #2731 were the correct one 😛 Does it make sense to open an issue for creating an option/preference for this after this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, the more I look at it the more sense it makes to make the default behavior aligned with the DocumentFormat.OpenXml.Bibliography
examples (the day example also uses the month's name).
There are other MS standards (e.g., dateGroupItem
on page 290) that doesn't, but this looks good to me.
Admittedly, I'd still love for there to be an option 😛
I thought so as well, but I don't think it's necessary. You can stil modfiy the xml by hand or edit it in Word internal ref manager. Regarding 2731, I think you refer to the getFieldOrAlias? Well this still works and it takes care of those magic bibtex macro strings as well (#jan#) jabref/src/main/java/org/jabref/model/entry/BibEntry.java Lines 957 to 959 in bb011c9
At least I took a second look and found that Object::toString is not anylonger necesary... |
True, I forgot that people use style files o.O
I spend too much time on ISO standards and not enough on the code X) |
* upstream/main: (354 commits) Fix ScienceDirect fetcher (#7684) Refactor NoBibTexFieldCheckerTest to increase mutation coverage (#7697) Update Gradle from 6.8.3 to 7.0 (#7619) Fixes #7305: the RFC fetcher is not compatible with the draftFix for issue 7305 (#7674) Refactoring existing unit tests (#7693) cover boundary cases & add more unit tests (#7694) Bump classgraph from 4.8.104 to 4.8.105 (#7688) Bump java-diff-utils from 4.9 to 4.10 (#7692) Fix arXiv fetcher tests (#7686) Make key for ScienceDirect configurable (#7683) migration of timestamp (#7671) Fix CCSB and DOAJ (#7426) [Bot] Update CSL styles (#7680) MS Office XML: Export month name (#7677) linkfix (#7678) readd fix (#7675) Fix threading cleanup in performSearch (#7672) add missing changelog delete bug fix (#7580) Add more unit tests to three gui classes (#7636) ... # Conflicts: # build.gradle
Fixes https://discourse.jabref.org/t/export-month-as-text-not-number/2685
The month field is also the full name in the example listed here https://docs.microsoft.com/de-de/dotnet/api/documentformat.openxml.bibliography.month?view=openxml-2.8.1
CHANGELOG.md
described in a way that is understandable for the average user (if applicable)