Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import hangs for ris files with "ER - " field, also other bib files common from journal web sites #7737

Closed
CodeSJS opened this issue May 15, 2021 · 7 comments · Fixed by #7775
Labels
bug Confirmed bugs or reports that are very likely to be bugs import

Comments

@CodeSJS
Copy link

CodeSJS commented May 15, 2021

JabRef version JabRef 5.3--2021-05-15--0a26d31
Windows 10 10.0 amd64
Java 16.0.1
JavaFX 16+8

Certain files I download from journals cause import to hang. (I looked through other bug reports concerning "import hangs" and this seems to be different. Apologies if duplicate.) The problem was perfectly reproducible in 5.2. In 5.3 some problem files occasionally load. If you cannot reproduce the bug, please try opening the problem files 3 or 4 times.

With ris files the problem is clear. When the ris file contains "ER - " as the last line, import (ctrl-I) hangs and I have to kill jabref and restart. Removing the last line solves the problem. This may be an illegal ris format, but many journal citation files end this way. I have provided examples from J. Chem. Phys., J. Phys. Chem., WIREs Comput. Mol Sci., and Biophys. J. It is interesting, but there is no problem opening such a file using right click, open with jabref.

Bib files from journals also give similar problems. I delete portions of the file until jabref does not hang. However, I have not pinned down the problem as I have with ris files. Examples of both ris and bib problem files will be attached.

I cannot post a log file example. When the import hangs and I have to "close program", the log is empty upon restart.

Several ris and bib files that cause problems are attached. The ris files all contain the "ER - " last line.

FilesThatCauseImportHangs.zip

Thank you.

@Siedlerchr Siedlerchr added import bug Confirmed bugs or reports that are very likely to be bugs labels May 15, 2021
@Noname690
Copy link
Contributor

I have reproduced this issue in the latest version . And I want try to fix it , could you give me some advise , thank you @Siedlerchr

@Siedlerchr
Copy link
Member

@Noname690 I would take a look at the RIS Importer and debug what happenns when the importer cones to this line.
You can also start with a Unit test to reproduce this

@CodeSJS
Copy link
Author

CodeSJS commented May 17, 2021 via email

@Noname690
Copy link
Contributor

4T2~J6YMXU}9066${JQTB5G
The entries after processing are like this , I think the problem may cause by that

@CodeSJS
Copy link
Author

CodeSJS commented May 19, 2021 via email

Noname690 added a commit to Noname690/jabref that referenced this issue May 20, 2021
Siedlerchr added a commit that referenced this issue May 29, 2021
…ame690-master

* 'master' of https://github.com/Noname690/jabref:
  add a test
  add a test for #7737
  fix RIS importer
  fix the ris importer
@Siedlerchr
Copy link
Member

@CodeSJS Thanks to @Noname690 this issue is now fixed in the latest development build http://builds.jabref.org/main

@CodeSJS
Copy link
Author

CodeSJS commented Jun 5, 2021 via email

@koppor koppor moved this to Done in Prioritization Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs import
Projects
Archived in project
3 participants