Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In CSL preview, journal title and series name are duplicated #8279

Closed
2 tasks done
wujastyk opened this issue Nov 26, 2021 · 14 comments · Fixed by #8329
Closed
2 tasks done

In CSL preview, journal title and series name are duplicated #8279

wujastyk opened this issue Nov 26, 2021 · 14 comments · Fixed by #8329
Labels
entry-preview status: depends-on-external A bug or issue that depends on an update of an external library

Comments

@wujastyk
Copy link

JabRef version

Latest development branch build (please note build date below)

Operating system

GNU / Linux

Details on version and operating system

JabRef 5.4--2021-11-25--7aaf5e2 Linux 5.11.0-40-generic amd64 Java 16.0.2 JavaFX 17.0.1+1

Checked with the latest development build

  • I made a backup of my libraries before testing the latest development version.
  • I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

  1. go to the preview tab for any article etc.
  2. Display has the journal title duplicated:

Journal:

image

Book in series:

image

I have tried a dozen or so different preview styles. Above are "Chicago Manual of Style 17th ed" and "Oxford Studies in Ancient Philosophy", but it's the same whatever style I choose.

I wouldn't mind editing the preview template to my liking, but that's currently not available

Appendix

@Article{wixt-2018,
  author           = {John T. Wixted and Laura Mickes and Ronald P. Fisher},
  date             = {2018-05},
  journal          = {Perspectives on Psychological Science},
  number           = {3},
  pages            = {324--335},
  title            = {Rethinking the Reliability of Eyewitness Memory},
  volume           = {13},
  doi              = {10.1177/1745691617734878},
  abstract         = {Although certain pockets within the broad field of academic psychology have come to appreciate that eyewitness memory is more reliable than was once believed, the prevailing view, by far, is that eyewitness memory is unreliable—a blanket assessment that increasingly pervades the legal system. On the surface, this verdict seems unavoidable: Research convincingly shows that memory is malleable, and eyewitness misidentifications are known to have played a role in most of the DNA exonerations of the innocent. However, we argue here that, like DNA evidence and other kinds of scientifically validated forensic evidence, eyewitness memory is reliable if it is not contaminated and if proper testing procedures are used. This conclusion applies to eyewitness memory broadly conceived, whether the test involves recognition (from a police lineup) or recall (during a police interview). From this perspective, eyewitness memory has been wrongfully convicted of mistakes that are better construed as having been committed by other actors in the legal system, not by the eyewitnesses themselves. Eyewitnesses typically provide reliable evidence on an initial, uncontaminated memory test, and this is true even for most of the wrongful convictions that were later reversed by DNA evidence.},
  creationdate     = {2021-11-26T11:28:38},
  modificationdate = {2021-11-26T11:58:46},
  publisher        = {{SAGE} Publications},
}

@Book{qvar-yoga2,
  author           = {Olle Qvarnström},
  date             = {2013},
  location         = {Mumbai},
  publisher        = {Hindi Granth Karyalay},
  title            = {A Handbook on the Three Jewels of Jainism: The Yogaśāstra of Hemacandra},
  edition          = {6},
  isbn             = {9780674009349},
  series           = {Harvard Oriental Series},
  comment          = {Revised edition of \cite{qvar-yoga}. Hemacandra lived in the late 11th century.},
  file             = {:Quarnström, O/Quarnström_The Yogasastra of Hemacandra_2002.pdf:PDF},
  modificationdate = {2018-09-17T00:00:00},
}


@ThiloteE
Copy link
Member

ThiloteE commented Nov 26, 2021

JabRef 5.4--2021-11-25--7ec4c7e
Windows 10 10.0 amd64
Java 16.0.2
JavaFX 17.0.1+1

I can second this. I have seen this a lot and it extends to the number field as well.

Here is the one from Modern Language Association 9th version:
image

@Article{Abdullah202005NNN,
  author       = {Walid Jumblatt Abdullah},
  date         = {2020-05},
  journaltitle = {Democratization},
  title        = {New Normal No More: Democratic Backsliding in Singapore After 2015},
  doi          = {10.1080/13510347.2020.1764940},
  number       = {7},
  pages        = {1123--1141},
  volume       = {27},
  file         = {:Abdullah (2020) New normal no more. Democratic backsliding in Singapore after 2015.pdf:PDF},
  publisher    = {Informa UK Limited},
}

@ThiloteE
Copy link
Member

The same shows up also under options>preferences>entry preview. Not all citationstyles do have this duplication, but many do. For some it is the journal field, for some it only is the number field.

@Siedlerchr
Copy link
Member

Question: Do you have bibtex or biblatex mode in your library? Does it make a difference?

@wujastyk
Copy link
Author

Normally biblatex. Tried changing to bibtex, both in main Preferences and in Library. No change.

@ThiloteE
Copy link
Member

Dito. I also tried to convert some entries from biblatex to bibtex style via cleanup entries to see if there was a change in the preview, but there was no change.

@Siedlerchr
Copy link
Member

The CSL Styles are here, they are updated automatically from the remote repo, maybe something from the last update went wrong?
https://github.com/JabRef/jabref/tree/main/buildres/csl

@ThiloteE
Copy link
Member

ThiloteE commented Nov 28, 2021

I just tested an entry with Zotero and there it works fine. See:

Thompson, Mark R. ‘Middle-Class Remorse: Re-Embracing Liberal Democracy in the Philippines and Thailand’. Global Asia, vol. 15, no. 1, East Asia Foundation, Mar. 2020, pp. 60–64.

In Jabref we have the dublicate. See:

image

I checked with Winmerge if the citation-style code is any different between the ones used by Zotero (https://www.zotero.org/styles/modern-language-association) and the one from Jabref (Options>preferences>entry preview>Modern Language Association 9th edition) and there was no difference.

Looks like it is more of an implementation problem.

@ThiloteE
Copy link
Member

Follow up: There is ONE difference when i copy the code from Jabref (Options>preferences>entry preview>Modern Language Association 9th edition>edit) into the editor (= the text editor on Windows 10) and save it as a textfile: According to Winmerge, both used different line-break format.

@wujastyk
Copy link
Author

Re: link

The CSL Styles are here, they are updated automatically from the remote repo, maybe something from the last update went wrong?

This has been an issue for a very long time. Maybe a year? I've just been living with it, and only thought to report it now.

@Siedlerchr Siedlerchr changed the title In preview, journal title and series name are duplicated In CSL preview, journal title and series name are duplicated Nov 29, 2021
@Siedlerchr
Copy link
Member

@ThiloteE Would you mind reporting the issue here with your investigation details? https://github.com/michel-kraemer/citeproc-java
JabRef is using this library for the handling of the CSL styles.

@Siedlerchr Siedlerchr added entry-preview status: depends-on-external A bug or issue that depends on an update of an external library labels Dec 3, 2021
@ThiloteE
Copy link
Member

"This issue is now fixed in citeproc-java v3.0.0-alpha.3" - michel-kraemer

@Siedlerchr
Copy link
Member

@ThiloteE Thanks. Should be picked up by the Dependabot tomorrow with a couple of other updates.

@ThiloteE
Copy link
Member

Awesome :-)

@wujastyk
Copy link
Author

Thank you, everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
entry-preview status: depends-on-external A bug or issue that depends on an update of an external library
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants