Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify open and import database action and show errors #8298

Open
2 tasks done
kristofmeixner opened this issue Dec 5, 2021 · 9 comments
Open
2 tasks done

Unify open and import database action and show errors #8298

kristofmeixner opened this issue Dec 5, 2021 · 9 comments
Assignees
Labels
bug Confirmed bugs or reports that are very likely to be bugs
Milestone

Comments

@kristofmeixner
Copy link
Contributor

JabRef version

5.3 (latest release)

Operating system

GNU / Linux

Details on version and operating system

No response

Checked with the latest development build

  • I made a backup of my libraries before testing the latest development version.
  • I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

  1. Open file bug-1.bib
  2. Only 2 of 3 entries are read
  3. Save the library
  4. The third entry is commented out (see file bug-2.bib)

Appendix

bug-1.txt
bug-2.txt

@Siedlerchr Siedlerchr added the bug Confirmed bugs or reports that are very likely to be bugs label Dec 5, 2021
@Siedlerchr
Copy link
Member

Siedlerchr commented Dec 5, 2021

When I copy the missing entry to the source tab of a new entry:

I think I found the issue, the problem is that the field name "Early Access Date =" contains spaces. That's why it's skipped.
The parsing error should be shown to the user as well

grafik

@kristofmeixner
Copy link
Contributor Author

kristofmeixner commented Dec 6, 2021

Okay, this seems more a Web of Science issue.
I wrote them an email.

But the parsing error wasn't shown to me.

@koppor koppor self-assigned this Dec 6, 2021
@koppor koppor added this to the v5.4 milestone Dec 6, 2021
@Siedlerchr
Copy link
Member

Stumbled across this warning not shown stuff as well: JabRef has two methods for opening bib files:

JabRefGUI -> openDatabases is called when JabRef is started and will show any errors/warnings from the parser.
The other code for opening is in "OpenDatabaseAction" which does not show any errors from parser Result.
The same applies for "ImportAction". In the latter, there is still a TODO comment...

@calixtus
Copy link
Member

We should try to unify these different methods.

@calixtus
Copy link
Member

Main Issue seems to be the whitespaces in the field name.

Deeplinks for information resources on field name conventions

@calixtus calixtus modified the milestones: v5.4, v6.0 Dec 20, 2021
@koppor koppor modified the milestones: v6.0, v5.6 Feb 18, 2022
@k3KAW8Pnf7mkmdSMPHz27
Copy link
Member

Refs. #8556 #8555 (merged methods might have prevented the issue)

@Siedlerchr Siedlerchr changed the title Web of Science Bibfile not read when opening and commented out when saving Unify open and import database action and show errors Mar 14, 2022
@calixtus
Copy link
Member

calixtus commented Mar 14, 2022

Background: There are three different methods to import/open bib files:

  • ImportAction/ImportCommand
  • OpenDatabaseAction
  • JabRefGui#openDatabases

@ThiloteE ThiloteE added this to the v5.8 milestone Jul 14, 2022
@koppor koppor mentioned this issue Aug 15, 2022
6 tasks
@koppor koppor modified the milestones: v5.8, v6.0 Sep 26, 2022
@koppor
Copy link
Member

koppor commented Jun 21, 2023

Another comment on the code is available at #361 (comment)

@koppor
Copy link
Member

koppor commented Apr 8, 2024

While working on this, #9714 should also be solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs
Projects
None yet
Development

No branches or pull requests

6 participants