-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refine BackupManager #9054
Refine BackupManager #9054
Conversation
Co-authored-by: Christoph <siedlerkiller@gmail.com> Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>
Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>
Co-authored-by: Christoph <siedlerkiller@gmail.com>
Co-authored-by: Christoph <siedlerkiller@gmail.com>
Follow-up: #2961 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me.
Is the backupmanager running in a seperate thread?
Is #8750 superceded by this PR? |
Ideas (if they are quick to implement)
In this way, we only create backups if necessary. I am not sure, however, if we the current change infrastructure trigger changes in all changes (e.g., change of encoding, change of groups, add a BibTeX string). At the event bus, I was pretty sure. Does anyone know about the new infrastructure? |
We still have the EventBus in place... But I would stick with creating backups always |
…manager # Conflicts: # CHANGELOG.md
Co-authored-by: Christoph <siedlerkiller@gmail.com>
- i: Reuse OpenDataBaseAction (instead of code duplication) - ii: Remove double initialization of BackupManager
Converted to draft, since I have to investigate the creation of BackupManger in the two cases i) restore at JabRef start and ii) file opening. Before the PR, the BackupManager was started and afterwards (!) it was checked if the backup file differed from the current file. Here, that lead to 0 byte backup files. |
Refs #8298 (comment): Partially fixes the issue regarding |
Co-authored-by: Christoph <siedlerkiller@gmail.com> Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com> Co-authored-by: ThiloteE <73715071+ThiloteE@users.noreply.github.com> Co-authored-by: Houssem Nasri <housi.housi2015@gmail.com> Co-authored-by: Benedikt Tutzer <btut@users.noreply.github.com>
* upstream/main: Restructure development documation (#9058) Refine BackupManager (#9054) No need for "synchronized" at autosave, because there is a throttler (#9060) Reenable CiteSeerTest (#9062) Bump mockito-core from 4.6.1 to 4.7.0 (#9061) Squashed 'buildres/csl/csl-styles/' changes from c750b6e..b9302fd (#9059)
Alleviates https://discourse.jabref.org/t/no-content-in-table-after-blue-screen/3479
.bak
and temporary writing files now.sav
..bib
file in the user data dir (instead of a single.sav
(now:.bak
) file in the directory of the.bib
file)CHANGELOG.md
described in a way that is understandable for the average user (if applicable)