Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add www.biodiversitylibrary.org to the websearch options #8539

Closed
RJDan opened this issue Mar 2, 2022 · 14 comments
Closed

Add www.biodiversitylibrary.org to the websearch options #8539

RJDan opened this issue Mar 2, 2022 · 14 comments
Labels
fetcher good first issue An issue intended for project-newcomers. Varies in difficulty.

Comments

@RJDan
Copy link

RJDan commented Mar 2, 2022

Older literature is not easily recovered by the available databases (particularly books).

Describe the solution you'd like
Have https://www.biodiversitylibrary.org/bibliography added to the available databases to aid in searching for (in this case, biology) material.

@Siedlerchr Siedlerchr added fetcher good first issue An issue intended for project-newcomers. Varies in difficulty. labels Mar 2, 2022
@Siedlerchr
Copy link
Member

Biology is not my research domain, but the site seems cool ;)
Some info about API can be found here:
https://about.biodiversitylibrary.org/tools-and-services/developer-and-data-tools/#APIs
Seems to be relatively straightforward to implement.

@Ankush142930
Copy link

Hey, I am Ankush. I am a newbie programmer, but I really want to contribute to this project(Open-source in general). Could you please guide me to resolve this issue?
I only know java, dsa and currently learning web development.

@Siedlerchr
Copy link
Member

Welcome to JabRef! Check out our Contribution Guide https://devdocs.jabref.org/contributing
As a starting point, look at the Fetchers in org/jabref/logic/importer/fetcher

@Ankush142930
Copy link

Okay, thanks a lot @Siedlerchr. I will do the aforesaid.

@Azhen917
Copy link

Azhen917 commented Mar 10, 2022

Hello, I am also new to open source contributions and I would love to help. Are there any articles or guides that I can read to understand how to implement this?

@Siedlerchr
Copy link
Member

See my comment above. In general, try to look into existing fetchers to understand how it's working in general. @etienne428 maybe can also add some hints on where to start (He's also currently working on fetchers)

@Azhen917
Copy link

Azhen917 commented Mar 15, 2022

@etienne428 Hello! Thanks for the guidance! I've been reading the implementation of the other fetchers and I've managed to come up with this so far:

I am currently lost as to what to do with the getParser method. Any further help is much appreciated!

@Azhen917
Copy link

Thanks for the tips, I've pushed the changes to my repo as instructed. Please let me know if I did anything improperly.

SwampTG added a commit to SwampTG/jabref that referenced this issue Apr 5, 2022
SwampTG added a commit to SwampTG/jabref that referenced this issue Apr 6, 2022
@DanielPortods
Copy link

Hi! I'm trying to contribute in that issue and i have a question. That API need a key to validate the request. Have some indication of how to work with that kind of variable or i can just define a static variable inside of the class?
That key is get with an email so i'm thinking if it's not a env variable situation...

@Jonathan-Oliveira
Copy link
Contributor

Hi! I'm trying to contribute in that issue and i have a question. That API need a key to validate the request. Have some indication of how to work with that kind of variable or i can just define a static variable inside of the class? That key is get with an email so i'm thinking if it's not a env variable situation...

Hi! I'm also trying to contribute. Checking the other implementations I found that there is a file that has the api keys. Look the file BuildInfo

@Siedlerchr
Copy link
Member

Yes, the BuildInfo is correct. You can use that for testing. During the Build we replace some of the APi keys there with keys from environment variables.

SwampTG added a commit to SwampTG/jabref that referenced this issue Apr 7, 2022
SwampTG added a commit to SwampTG/jabref that referenced this issue Apr 8, 2022
DanielPortods referenced this issue in DanielPortods/jabref Apr 14, 2022
DanielPortods referenced this issue in DanielPortods/jabref Apr 15, 2022
Jonathan-Oliveira added a commit to Jonathan-Oliveira/jabref that referenced this issue Apr 15, 2022
Jonathan-Oliveira added a commit to Jonathan-Oliveira/jabref that referenced this issue Apr 15, 2022
koppor added a commit that referenced this issue May 9, 2022
Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>
Co-authored-by: Christoph <siedlerkiller@gmail.com>
Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>
@koppor
Copy link
Member

koppor commented May 9, 2022

Thank you for reporting this issue. We think, that is already implemented in our development version and consequently the change will be included in the next release.

We would like to ask you to use a development build from https://builds.jabref.org/main.

@koppor koppor closed this as completed May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fetcher good first issue An issue intended for project-newcomers. Varies in difficulty.
Projects
Archived in project
Development

No branches or pull requests

8 participants
@Siedlerchr @koppor @RJDan @DanielPortods @Jonathan-Oliveira @Azhen917 @Ankush142930 and others