Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog link leads to a 404 #8563

Closed
2 tasks done
wujastyk opened this issue Mar 13, 2022 · 7 comments · Fixed by #8578
Closed
2 tasks done

Changelog link leads to a 404 #8563

wujastyk opened this issue Mar 13, 2022 · 7 comments · Fixed by #8578
Labels
good first issue An issue intended for project-newcomers. Varies in difficulty.

Comments

@wujastyk
Copy link

JabRef version

Latest development branch build (please note build date below)

Operating system

GNU / Linux

Details on version and operating system

JabRef 5.6--2022-03-11--89d1047 Linux 5.13.0-35-generic amd64 Java 17.0.2 JavaFX 17.0.2-ea+3

Checked with the latest development build

  • I made a backup of my libraries before testing the latest development version.
  • I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

  1. Select help / JabRef resources / view change log
  2. Taken to https://github.com/JabRef/jabref/blob/master/CHANGELOG.md
  3. 404 message.
  4. Should be https://github.com/JabRef/jabref/blob/main/CHANGELOG.md (main, not master)

Appendix

...

Log File
Paste an excerpt of your log file here
@Siedlerchr Siedlerchr added the good first issue An issue intended for project-newcomers. Varies in difficulty. label Mar 13, 2022
@NYH-Dolphin
Copy link
Contributor

Hi, I am a junior student who is learning software engineering, I have successfully build the environment in JabRef and I am wondering whether I can try to solve this problem~

@NYH-Dolphin
Copy link
Contributor

Plus, I find the same problem when the operating system is Windows10

@NYH-Dolphin
Copy link
Contributor

NYH-Dolphin commented Mar 14, 2022

Dear JabRef:
Well, I have located this bug position and create a branch called fix-for-issue-8563 in my own folk repo.
Plus, I would like to propose a new revise suggestion. In your version Tags I found several versions as the following shortcut
image
As you see v4.0 has 4 subversions, v4.0/v4.0-beta/v4.0-beta2/v4.0-beta3, which means if I use JabRef to check the latest version, it should have driected me into the [version]-[subversion] Tag according to the Version type you specified
However, I write the following testcase but it fails
image
In your class main/org/jabref/logic/util/Version.java, there must be some revise points, could you let me further revise it in order to fit to perse certain version into correct website link?

@Siedlerchr
Copy link
Member

I would propose to debug through the failing Tests and set a breakpoint in Version.parse method

@NYH-Dolphin
Copy link
Contributor

NYH-Dolphin commented Mar 15, 2022

I would propose to debug through the failing Tests and set a breakpoint in Version.parse method

I will do that~ What I mean is that this may be a defect in the JabRef and I am wondering whether I can try to fix it on issue #8563 and then make a pull request?

@Siedlerchr
Copy link
Member

Yes sure, as long it's related to the issue it's fine!

@NYH-Dolphin
Copy link
Contributor

NYH-Dolphin commented Mar 17, 2022

hey JabRef~
I almost finish to fix this issue. However, when I try to push it to my branch, the gradlew check is fail and tells me the following message
image
May I need to update my local JRE version?

It's okay, I have re-setup the environment and my JDK version, and it seems work~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue An issue intended for project-newcomers. Varies in difficulty.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants